chore: add local shellcheck tools#521
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Oct 13, 2022
Merged
Conversation
Xunzhuo
force-pushed
the
chore-shellcheck
branch
5 times, most recently
from
91c1e8d to
5efdc93
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 63.48% 60.28% -3.20%
==========================================
Files 40 45 +5
Lines 4425 5564 +1139
==========================================
+ Hits 2809 3354 +545
- Misses 1471 2003 +532
- Partials 145 207 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
reviewed
Oct 9, 2022
Xunzhuo
force-pushed
the
chore-shellcheck
branch
from
1aacf28 to
8ce2fcb
Compare
arkodg
reviewed
Oct 10, 2022
Xunzhuo
force-pushed
the
chore-shellcheck
branch
from
8ce2fcb to
2d5b885
Compare
arkodg
reviewed
Oct 11, 2022
LukeShu
suggested changes
Oct 11, 2022
Xunzhuo
force-pushed
the
chore-shellcheck
branch
from
2d5b885 to
01892f4
Compare
Signed-off-by: bitliu <[email protected]>
Xunzhuo
force-pushed
the
chore-shellcheck
branch
from
01892f4 to
bf3a8dd
Compare
Xunzhuo
requested review from
LukeShu and
arkodg
and removed request for
LukeShu
Member
Author
|
Thanks @LukeShu, updated based on your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve: #314
Signed-off-by: bitliu [email protected]