Skip to content

Conversation

@nothinux
Copy link
Contributor

@nothinux nothinux commented Nov 30, 2024

What type of PR is this?
continuation for this PR to increase the max items in backend endpoints #4803

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4793

Release Notes: No

arkodg
arkodg previously approved these changes Nov 30, 2024
@zirain
Copy link
Member

zirain commented Dec 1, 2024

@nothinux can you run make -k gen-check to make CI happy?

Signed-off-by: Taufik Mulyana <[email protected]>
@nothinux
Copy link
Contributor Author

nothinux commented Dec 1, 2024

apologiez I forgot to run the test, I've updated the PR

@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (81faf42) to head (a84953b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4822      +/-   ##
==========================================
- Coverage   65.60%   65.59%   -0.01%     
==========================================
  Files         211      211              
  Lines       31999    31999              
==========================================
- Hits        20994    20991       -3     
- Misses       9761     9764       +3     
  Partials     1244     1244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zhaohuabing zhaohuabing merged commit 93ac055 into envoyproxy:main Dec 2, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hostname doesn't support subdomain with single character in Backend Object

4 participants