revisit envoy shutdown settings#4288
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom Sep 21, 2024
Merged
Conversation
* Set default minDrainDuration to `10s` . Since the default `readinessProbe.periodSeconds` is `5s`, this gives any LB controller `5s` to update its endpoint pool if its basing it off the k8s API server * Set default `drainTimeout` to `60s`. This ensures clients holding persistent connections, can be closed sooner. Fixes: envoyproxy#4125 * Updates the default `terminationGracePeriodSeconds` to `360s` which is `300s` more than the default drain timeout Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
==========================================
+ Coverage 65.64% 65.66% +0.01%
==========================================
Files 197 197
Lines 23555 23557 +2
==========================================
+ Hits 15462 15468 +6
+ Misses 6982 6981 -1
+ Partials 1111 1108 -3 ☔ View full report in Codecov by Sentry. |
shawnh2
approved these changes
Sep 21, 2024
zirain
approved these changes
Sep 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10s. Since the defaultreadinessProbe.periodSecondsis5s, this gives any LB controller5sto update its endpoint pool if its basing it off the k8s API serverdrainTimeoutto60s. This ensures clients holding persistent connections, can be closed sooner.Fixes: Graceful shutdown drain not happening due to prometheus #4125
terminationGracePeriodSecondsto360swhich is300smore than the default drain timeout