Skip to content

chore: update grafana dashboards#3746

Merged
Xunzhuo merged 4 commits intoenvoyproxy:mainfrom
shawnh2:update-dashboard
Jul 6, 2024
Merged

chore: update grafana dashboards#3746
Xunzhuo merged 4 commits intoenvoyproxy:mainfrom
shawnh2:update-dashboard

Conversation

@shawnh2
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 commented Jul 4, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

follow-up of #3727, fix #3703

@shawnh2 shawnh2 requested a review from a team as a code owner July 4, 2024 04:10
@shawnh2
fix gen-check
d3ebe80 
Signed-off-by: shawnh2 <[email protected]>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (abb7c96) to head (d8d89ff).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3746      +/-   ##
==========================================
- Coverage   69.05%   69.00%   -0.06%     
==========================================
  Files         176      176              
  Lines       21751    21751              
==========================================
- Hits        15021    15010      -11     
- Misses       5652     5661       +9     
- Partials     1078     1080       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Copy Markdown
Member

zirain commented Jul 4, 2024

can you try to refactor dashboard with https://github.com/istio/istio/blob/395b9bb706a4fcb8633beac188b64707d7e7a1f1/manifests/addons/dashboards/README.md to make it maintainable?

@shawnh2
Copy link
Copy Markdown
Contributor Author

shawnh2 commented Jul 5, 2024

can you try to refactor dashboard with https://github.com/istio/istio/blob/395b9bb706a4fcb8633beac188b64707d7e7a1f1/manifests/addons/dashboards/README.md to make it maintainable?

this may require a lot of refactor work, raise another issue to track it.

@shawnh2 shawnh2 mentioned this pull request Jul 5, 2024
Closed
@shawnh2
Copy link
Copy Markdown
Contributor Author

shawnh2 commented Jul 5, 2024

/retest

@zirain zirain requested review from a team July 5, 2024 23:42
Xunzhuo
Xunzhuo approved these changes Jul 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Xunzhuo Xunzhuo merged commit 007617a into envoyproxy:main Jul 6, 2024
@shawnh2 shawnh2 deleted the update-dashboard branch July 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Export WASM metrics into Grafana dashboard

3 participants

@shawnh2 @zirain @Xunzhuo