Skip to content

e2e: fix accesslog test#3736

Merged
Alice-Lilith merged 2 commits intoenvoyproxy:mainfrom
zirain:fix-accesslog-e2e
Jul 3, 2024
Merged

e2e: fix accesslog test#3736
Alice-Lilith merged 2 commits intoenvoyproxy:mainfrom
zirain:fix-accesslog-e2e

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jul 3, 2024

No description provided.

@zirain zirain requested a review from a team as a code owner July 3, 2024 02:43
- format:
type: Text
text: |
[%START_TIME%] "%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%" %RESPONSE_CODE% %RESPONSE_FLAGS% %BYTES_RECEIVED% %BYTES_SENT% %DURATION% "%REQ(X-FORWARDED-FOR)%" "%REQ(USER-AGENT)%" "%REQ(X-REQUEST-ID)%" "%REQ(:AUTHORITY)%" "%UPSTREAM_HOST%"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

METADATA not support on ALS, will investigate later.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.07%. Comparing base (4602f6d) to head (1d58201).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
+ Coverage   69.05%   69.07%   +0.01%     
==========================================
  Files         176      176              
  Lines       21688    21688              
==========================================
+ Hits        14977    14980       +3     
+ Misses       5632     5629       -3     
  Partials     1079     1079              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jul 3, 2024

/retest

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jul 3, 2024

/retest

@Alice-Lilith Alice-Lilith merged commit de8a53d into envoyproxy:main Jul 3, 2024
@zirain zirain deleted the fix-accesslog-e2e branch July 3, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants