refactor: rename control-plane metrics#3727
Merged
zirain merged 8 commits intoenvoyproxy:mainfrom Jul 3, 2024
Merged
Conversation
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 68.81% 68.76% -0.05%
==========================================
Files 175 175
Lines 21524 21523 -1
==========================================
- Hits 14811 14800 -11
- Misses 5636 5647 +11
+ Partials 1077 1076 -1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
will update grafana dashboard in a follow-up PR |
Signed-off-by: shawnh2 <[email protected]>
Alice-Lilith
approved these changes
Jul 3, 2024
Member
Alice-Lilith
left a comment
Alice-Lilith
left a comment
There was a problem hiding this comment.
I'm good with the general good approach, but should fix CI before merging
Contributor
Author
|
/retest |
zirain
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3684