follow-up: update docs and ci pipeline to utilize gateway-addons-helm#3610
Merged
zirain merged 11 commits intoenvoyproxy:mainfrom Jun 22, 2024
Merged
follow-up: update docs and ci pipeline to utilize gateway-addons-helm#3610zirain merged 11 commits intoenvoyproxy:mainfrom
zirain merged 11 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3610 +/- ##
==========================================
- Coverage 68.38% 68.35% -0.03%
==========================================
Files 170 170
Lines 20707 20707
==========================================
- Hits 14160 14155 -5
- Misses 5527 5530 +3
- Partials 1020 1022 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
shawnh2
changed the title
Contributor
Author
|
/retest |
Signed-off-by: shawnh2 <[email protected]>
zirain
reviewed
Jun 16, 2024
site/content/en/latest/tasks/observability/rate-limit-observability.md
Outdated
Show resolved
Hide resolved
Signed-off-by: shawnh2 <[email protected]>
shawnh2
commented
Jun 17, 2024
Signed-off-by: shawnh2 <[email protected]>
Contributor
Author
|
/retest |
Signed-off-by: shawnh2 <[email protected]>
shawnh2
commented
Jun 20, 2024
cnvergence
approved these changes
Jun 20, 2024
arkodg
previously approved these changes
Jun 20, 2024
Signed-off-by: shawnh2 <[email protected]>
Member
|
/retest |
zirain
approved these changes
Jun 22, 2024
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 24, 2024
…envoyproxy#3610) * update opentelemetry-collector version Signed-off-by: shawnh2 <[email protected]> * update makefile cmd to utilize gateway-addons-helm Signed-off-by: shawnh2 <[email protected]> * update docs according to gateway-addons-helm Signed-off-by: shawnh2 <[email protected]> * correct prometheus server name config Signed-off-by: shawnh2 <[email protected]> * fix e2e test labels Signed-off-by: shawnh2 <[email protected]> * correct grafana datasource url Signed-off-by: shawnh2 <[email protected]> * add template doc Signed-off-by: shawnh2 <[email protected]> * specify helm-generate Signed-off-by: shawnh2 <[email protected]> * remove tags Signed-off-by: shawnh2 <[email protected]> * fix gen-check Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: “bjlhlin” <“[email protected]”> Signed-off-by: bjlhlin <[email protected]>
bjlhlin
pushed a commit
to bjlhlin/gateway
that referenced
this pull request
Jun 26, 2024
…envoyproxy#3610) * update opentelemetry-collector version Signed-off-by: shawnh2 <[email protected]> * update makefile cmd to utilize gateway-addons-helm Signed-off-by: shawnh2 <[email protected]> * update docs according to gateway-addons-helm Signed-off-by: shawnh2 <[email protected]> * correct prometheus server name config Signed-off-by: shawnh2 <[email protected]> * fix e2e test labels Signed-off-by: shawnh2 <[email protected]> * correct grafana datasource url Signed-off-by: shawnh2 <[email protected]> * add template doc Signed-off-by: shawnh2 <[email protected]> * specify helm-generate Signed-off-by: shawnh2 <[email protected]> * remove tags Signed-off-by: shawnh2 <[email protected]> * fix gen-check Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: bjlhlin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
follow-op of #3541
Which issue(s) this PR fixes:
Fixes #3355