Adds Initial Support for Infra IR Metadata#350
Merged
danehans merged 1 commit intoenvoyproxy:mainfrom Sep 8, 2022
Merged
Conversation
Signed-off-by: danehans <[email protected]>
danehans
added
area/ir
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 58.66% 58.92% +0.26%
==========================================
Files 32 32
Lines 2869 2907 +38
==========================================
+ Hits 1683 1713 +30
- Misses 1087 1097 +10
+ Partials 99 97 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Sep 7, 2022
LukeShu
approved these changes
Sep 8, 2022
Contributor
LukeShu
left a comment
LukeShu
left a comment
There was a problem hiding this comment.
I hadn't realized that selflink was deprecated. lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadata.labelsto the ProxyInfra IR. This allows the gatewayapi translator to plumb metadata from Gateway API resources, e.g. Gateway ns/name, into managed infra without polluting the IR with Gateway API-isms.Note:
selfLinkis not used for metadata IR since it's deprecated and no longer set by Kubernetes.Fixes #173
Signed-off-by: danehans [email protected]