helm: add envoy gateway addon helm chart support by shawnh2 · Pull Request #3470 · envoyproxy/gateway

shawnh2 · 2024-05-24T08:13:36Z

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref #3355

Signed-off-by: shawnh2 <[email protected]>

charts/dashboard-addon/dashboards/envoy-clusters.json

codecov · 2024-05-24T08:18:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.17%. Comparing base (3712659) to head (0e7436e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
+ Coverage   68.12%   68.17%   +0.04%     
==========================================
  Files         165      165              
  Lines       20122    20122              
==========================================
+ Hits        13708    13718      +10     
+ Misses       5416     5409       -7     
+ Partials      998      995       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

charts/dashboard-addon/Chart.yaml

charts/dashboard-addon/Chart.lock

shawnh2 · 2024-05-27T07:31:40Z

This PR only include DP metrics and Grafana support, will send another PR to include CP metrics as well (#3474 (comment))

Signed-off-by: shawnh2 <[email protected]>

charts/gateway-addon/Chart.yaml

arkodg · 2024-05-29T01:52:32Z

hey @shawnh2 , @zhaohuabing @guydc and I brought this up in the community meeting today and aligned on

calling this chart gateway-demo-helm
adding envoy gateway as a sub chart (sorry for the churn here)

shawnh2 · 2024-05-30T15:01:27Z

This PR only include DP metrics and Grafana support, will send another PR to include CP metrics as well (#3474 (comment))

Lets include Grafana dashboard for CP as well, so wait until #3506 landed.

and the doc under https://gateway.envoyproxy.io/latest/tasks/observability/ can be updated with this helm demo support.

…rad-addon

shawnh2 · 2024-05-31T04:24:23Z

hey @shawnh2 , @zhaohuabing @guydc and I brought this up in the community meeting today and aligned on

calling this chart gateway-demo-helm

adding envoy gateway as a sub chart (sorry for the churn here)

If we are including envoy-gateway helm as well, we may not install this demo chart just using one helm install, cause eg and prom/grafana should be installed at different namespace. But helm does not support installing dependencies at different namespace. xref: helm/helm#10905

So:

Do we accpet installing all the dependencies at the same one namespace?
There's another tool helmfile could solve this problem, but will introduce more operations for users.
I can understand why we are trying to include eg as a dependency, to provide users with a one-stop eg-with-addons experience. But exclude eg does not affect this, we still can provide one-stop abilities for all the addons. And can solve this problem more easily.

arkodg · 2024-05-31T21:10:57Z

ah then lets go with the previous approach of gateway-addons-helm and rm envoy-gateway from this chart

Signed-off-by: shawnh2 <[email protected]>

tools/make/helm.mk

…rad-addon

Signed-off-by: shawnh2 <[email protected]>

arkodg

LGTM thanks !

arkodg · 2024-06-04T19:26:16Z

hey @phlax once this PR merges, we'll be pushing a new Helm Chart envoyproxy/gateway-addons-helm , will the CI be able to push using the existing PAT or do we need to create the repo in dockerhub before hand ?

zirain

LGTM, may need wait @phlax first.

* initial dashboard addon helm chart Signed-off-by: shawnh2 <[email protected]> * rename addon name and remove gateway-helm support Signed-off-by: shawnh2 <[email protected]> * remove /charts from .helmignore Signed-off-by: shawnh2 <[email protected]> * rename to gateway-addons-helm and keep one source of truth Signed-off-by: shawnh2 <[email protected]> * restore examples values and fix comments Signed-off-by: shawnh2 <[email protected]> * rewrite helm makefile Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: phantooom <[email protected]>

* helm: add envoy gateway addon helm chart support (#3470) * initial dashboard addon helm chart Signed-off-by: shawnh2 <[email protected]> * rename addon name and remove gateway-helm support Signed-off-by: shawnh2 <[email protected]> * remove /charts from .helmignore Signed-off-by: shawnh2 <[email protected]> * rename to gateway-addons-helm and keep one source of truth Signed-off-by: shawnh2 <[email protected]> * restore examples values and fix comments Signed-off-by: shawnh2 <[email protected]> * rewrite helm makefile Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: phantooom <[email protected]> * chore: Remove namespace restriction for EnvoyProxy parametersRef resource Signed-off-by: phantooom <[email protected]> * chore: add CEL validation for BackendRef Group Signed-off-by: phantooom <[email protected]> * chore: add CEL validation for BackendRef Group Signed-off-by: phantooom <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Signed-off-by: phantooom <[email protected]> Co-authored-by: sh2 <[email protected]> Co-authored-by: zirain <[email protected]>

initial dashboard addon helm chart

c92c0e3

Signed-off-by: shawnh2 <[email protected]>

shawnh2 commented May 24, 2024

View reviewed changes

charts/dashboard-addon/dashboards/envoy-clusters.json Show resolved Hide resolved

zirain reviewed May 24, 2024

View reviewed changes

charts/dashboard-addon/Chart.yaml Outdated Show resolved Hide resolved

arkodg reviewed May 24, 2024

View reviewed changes

charts/dashboard-addon/Chart.lock Outdated Show resolved Hide resolved

shawnh2 added 2 commits May 27, 2024 17:21

rename addon name and remove gateway-helm support

2a81024

Signed-off-by: shawnh2 <[email protected]>

remove /charts from .helmignore

3be2b46

Signed-off-by: shawnh2 <[email protected]>

shawnh2 changed the title ~~helm: add dashboard addon helm chart~~ helm: add envoy gateway addon helm chart support May 28, 2024

arkodg reviewed May 28, 2024

View reviewed changes

charts/gateway-addon/Chart.yaml Show resolved Hide resolved

Merge branch 'main' of github.com:envoyproxy/gateway into helm-dashbo…

1ce45ef

…rad-addon

rename to gateway-addons-helm and keep one source of truth

16e39df

Signed-off-by: shawnh2 <[email protected]>

shawnh2 requested review from arkodg and zirain June 1, 2024 03:34

shawnh2 marked this pull request as ready for review June 1, 2024 03:36

shawnh2 requested a review from a team as a code owner June 1, 2024 03:36

restore examples values and fix comments

51a3a9d

Signed-off-by: shawnh2 <[email protected]>

arkodg reviewed Jun 3, 2024

View reviewed changes

tools/make/helm.mk Outdated Show resolved Hide resolved

shawnh2 added 2 commits June 4, 2024 11:48

Merge branch 'main' of github.com:envoyproxy/gateway into helm-dashbo…

80ba88b

…rad-addon

rewrite helm makefile

0e7436e

Signed-off-by: shawnh2 <[email protected]>

arkodg approved these changes Jun 4, 2024

View reviewed changes

arkodg requested review from a team June 4, 2024 19:24

zirain approved these changes Jun 4, 2024

View reviewed changes

guydc approved these changes Jun 4, 2024

View reviewed changes

arkodg merged commit 607d8bc into envoyproxy:main Jun 4, 2024

shawnh2 deleted the helm-dashborad-addon branch June 4, 2024 22:44

shawnh2 mentioned this pull request Jun 5, 2024

helm: add ServiceMonitor resource #2260

Closed

guydc mentioned this pull request Jun 6, 2024

fix: doc broken links #3553

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

helm: add envoy gateway addon helm chart support#3470

helm: add envoy gateway addon helm chart support#3470
arkodg merged 8 commits intoenvoyproxy:mainfrom
shawnh2:helm-dashborad-addon

shawnh2 commented May 24, 2024

Uh oh!

Uh oh!

codecov bot commented May 24, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

shawnh2 commented May 27, 2024

Uh oh!

Uh oh!

arkodg commented May 29, 2024

Uh oh!

shawnh2 commented May 30, 2024 •

edited

Loading

Uh oh!

shawnh2 commented May 31, 2024

Uh oh!

arkodg commented May 31, 2024

Uh oh!

Uh oh!

arkodg left a comment

Uh oh!

arkodg commented Jun 4, 2024 •

edited

Loading

Uh oh!

zirain left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

shawnh2 commented May 24, 2024

Uh oh!

Uh oh!

codecov bot commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

shawnh2 commented May 27, 2024

Uh oh!

Uh oh!

arkodg commented May 29, 2024

Uh oh!

shawnh2 commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnh2 commented May 31, 2024

Uh oh!

arkodg commented May 31, 2024

Uh oh!

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

arkodg commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zirain left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented May 24, 2024 •

edited

Loading

shawnh2 commented May 30, 2024 •

edited

Loading

arkodg commented Jun 4, 2024 •

edited

Loading