Skip to content

api: support IdleTimeout in clientTrafficPolicy#3042

Merged
arkodg merged 22 commits intoenvoyproxy:mainfrom
yaelSchechter:idle-timeout-api
Mar 28, 2024
Merged

api: support IdleTimeout in clientTrafficPolicy#3042
arkodg merged 22 commits intoenvoyproxy:mainfrom
yaelSchechter:idle-timeout-api

Conversation

@yaelSchechter
Copy link
Copy Markdown
Contributor

What type of PR is this?
Support idle timeout in ClientTrafficPolicy.

Fixes #2861

@yaelSchechter yaelSchechter requested a review from a team as a code owner March 27, 2024 15:49
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.50%. Comparing base (3d51933) to head (890c3f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3042   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files         121      121           
  Lines       21397    21397           
=======================================
  Hits        13803    13803           
  Misses       6723     6723           
  Partials      871      871           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Mar 28, 2024

one nit to fix godoc strings, else looks good !

arkodg
arkodg previously approved these changes Mar 28, 2024
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

dependabot bot and others added 21 commits March 28, 2024 10:02
…nvoyproxy#3010)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.50.0 to 0.51.1.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.50.0...v0.51.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
…#3011)

Bumps [fortio.org/fortio](https://github.com/fortio/fortio) from 1.63.4 to 1.63.5.
- [Release notes](https://github.com/fortio/fortio/releases)
- [Commits](fortio/fortio@v1.63.4...v1.63.5)

---
updated-dependencies:
- dependency-name: fortio.org/fortio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
* Add Chinese support for doc site

Signed-off-by: Wilson Wu <[email protected]>

* Add zh i18n for menus

Signed-off-by: Wilson Wu <[email protected]>

* Add zh content placeholders

Signed-off-by: Wilson Wu <[email protected]>

* Fix about zh page

Signed-off-by: Wilson Wu <[email protected]>

* Apply suggestions from code review

Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Wilson Wu <[email protected]>

* docs: `%s/Application/API/g` (envoyproxy#2929)

Signed-off-by: Wilson Wu <[email protected]>

* remove old version for zh content

Signed-off-by: Wilson Wu <[email protected]>

* Update the latest version link

Signed-off-by: Wilson Wu <[email protected]>

* Fix default content dir

Signed-off-by: Wilson Wu <[email protected]>

* Translate landing page and fix broken link

Signed-off-by: Wilson Wu <[email protected]>

* Fix broken link

Signed-off-by: Wilson Wu <[email protected]>

* Add a contribution page

Signed-off-by: Wilson Wu <[email protected]>

---------

Signed-off-by: Wilson Wu <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
* implement connection limit

Signed-off-by: Guy Daich <[email protected]>

* fix lint

Signed-off-by: Guy Daich <[email protected]>

* fix lint 2

Signed-off-by: Guy Daich <[email protected]>

* fix ir, coverage

Signed-off-by: Guy Daich <[email protected]>

* fix lint 3

Signed-off-by: Guy Daich <[email protected]>

* open more connection in e2e

Signed-off-by: Guy Daich <[email protected]>

* fix error type

Signed-off-by: Guy Daich <[email protected]>

* add additional connections

Signed-off-by: Guy Daich <[email protected]>

* make limit value required

Signed-off-by: Guy Daich <[email protected]>

* add error-flow unit test

Signed-off-by: Guy Daich <[email protected]>

* fix lint 4

Signed-off-by: Guy Daich <[email protected]>

* assert policy accepted in test

Signed-off-by: Guy Daich <[email protected]>

* rename limit => connectionLimit

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: yuluo <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
…roxy#3028)

fix attribute name

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
* docs: document patches in envoy proxy

Signed-off-by: Yael Shechter <[email protected]>

* fix linting issue

Signed-off-by: Yael Shechter <[email protected]>

* fix pr comment

Signed-off-by: Yael Shechter <[email protected]>

---------

Signed-off-by: Yael Shechter <[email protected]>
* Adding BTP support for UDP/TCP Routes

Signed-off-by: Alexander Volchok <[email protected]>

* fixining lint

Signed-off-by: Alexander Volchok <[email protected]>

* fix IdleTime check

Signed-off-by: Alexander Volchok <[email protected]>

* adding missing generates

Signed-off-by: Alexander Volchok <[email protected]>

* fixing code review comments

Signed-off-by: Alexander Volchok <[email protected]>

* incresing code coverage

Signed-off-by: Alexander Volchok <[email protected]>

---------

Signed-off-by: Alexander Volchok <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
* fix: add missing http filters to the http filter chain

Signed-off-by: huabing zhao <[email protected]>

* refactor

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* add comments

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* remove refactor

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: Fabrice Aneche <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
…nvoyproxy#3030)

added option to specify resources on the OIDC filter

Signed-off-by: jaynis <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
allow websockets in url rewrite

Signed-off-by: Jesse Haka <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
@guydc
Copy link
Copy Markdown
Contributor

guydc commented Mar 28, 2024

/retest

1 similar comment
@yaelSchechter
Copy link
Copy Markdown
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add support to configuring downstream idle timeout