Run certgen when upgrading by zhaohuabing · Pull Request #2934 · envoyproxy/gateway

zhaohuabing · 2024-03-15T07:11:25Z

Run certgen when upgrading EG helm chart because a new secret(HMAC) has been added after v0.0.6, and more may be added later.

Fix #2930

Signed-off-by: huabing zhao <[email protected]>

codecov · 2024-03-15T07:16:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.57%. Comparing base (36505f4) to head (6994bf7).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
- Coverage   64.59%   64.57%   -0.02%     
==========================================
  Files         122      122              
  Lines       21115    21115              
==========================================
- Hits        13640    13636       -4     
- Misses       6630     6632       +2     
- Partials      845      847       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zirain · 2024-03-15T07:42:49Z

is there anyway to make sure it worked as excepted?

zhaohuabing · 2024-03-15T07:51:48Z

is there anyway to make sure it worked as excepted?

Just manually tested it on my dev environment：-）

zirain · 2024-03-15T08:01:53Z

is there anyway to make sure it worked as excepted?

Just manually tested it on my dev environment：-）

I recall there's an upgrade test?

zhaohuabing · 2024-03-15T09:02:37Z

The test looks like uninstalling the old version and then installing the new version, not exactly helm upgrade.

We should have a proper upgrade test that helm upgrade the old release and run all the conformance tests and e2e tests on the upgrade version, this could be solved later.

gateway/test/e2e/tests/eg_upgrade.go

Lines 66 to 72 in 36505f4

    
           err := helmUninstall(relName, depNS, t) 
        
           if err != nil { 
        
           	t.Fatalf("Failed to upgrade the release: %s", err.Error()) 
        
           } 
        
           t.Log("Install the last version tag") 
        
           err = helmInstall(relName, depNS, lastVersionTag, suite.TimeoutConfig.NamespacesMustBeReady, t)

zirain · 2024-03-15T09:28:48Z

The test looks like uninstalling the old version and then installing the new version, not exactly helm upgrade.

We should have a proper upgrade test that helm upgrade the old release and run all the conformance tests and e2e tests on the upgrade version, this could be solved later.

gateway/test/e2e/tests/eg_upgrade.go

Lines 66 to 72 in 36505f4

err := helmUninstall(relName, depNS, t)

if err != nil {

t.Fatalf("Failed to upgrade the release: %s", err.Error())

}

t.Log("Install the last version tag")

err = helmInstall(relName, depNS, lastVersionTag, suite.TimeoutConfig.NamespacesMustBeReady, t)

can you update the test?

guydc · 2024-03-15T12:21:25Z

@zhaohuabing , @zirain
The test is:

Uninstalling main (in use by the regular conformance/e2e suite)
Installing latest rel
Upgrading from latest rel => main

gateway/test/e2e/tests/eg_upgrade.go

Line 81 in 36505f4

err = helmUpgradeChartFromPath(relName, depNS, "../../../charts/gateway-helm", suite.TimeoutConfig.NamespacesMustBeReady, t)

guydc · 2024-03-15T12:47:08Z

Are there any possible adverse effects? e.g. will cert-gen override some other existing secrets that may block installation or break the pre-upgraded instance? For example, if some components are not dynamically reloading these secrets?

zhaohuabing · 2024-03-15T13:16:49Z

Are there any possible adverse effects? e.g. will cert-gen override some other existing secrets that may block installation or break the pre-upgraded instance? For example, if some components are not dynamically reloading these secrets?

Just adds the missing HMAC secret, won't overwrite existing ones. I think the upgrade test has already covered this upgrade (from v 0.0.6 to the latest) , right? @guydc

run certgen when upgrading Signed-off-by: huabing zhao <[email protected]> (cherry picked from commit 62ecf15) Signed-off-by: Arko Dasgupta <[email protected]>

* Run certgen when upgrading (#2934) run certgen when upgrading Signed-off-by: huabing zhao <[email protected]> (cherry picked from commit 62ecf15) Signed-off-by: Arko Dasgupta <[email protected]> * Fix: nil secret in resourceversiontable (#2982) * fix nil secret in resourceversiontable Signed-off-by: huabing zhao <[email protected]> * check secrets in the xds result Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> (cherry picked from commit e880439) Signed-off-by: Arko Dasgupta <[email protected]> * fix: add missing http filters to the http filter chain (#2970) * fix: add missing http filters to the http filter chain Signed-off-by: huabing zhao <[email protected]> * refactor Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: huabing zhao <[email protected]> * add comments Signed-off-by: huabing zhao <[email protected]> * remove refactor Signed-off-by: huabing zhao <[email protected]> * remove refactor Signed-off-by: huabing zhao <[email protected]> * fix gen Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit f699edf) Signed-off-by: Arko Dasgupta <[email protected]> * fix: allow websockets in url rewrite (#3022) allow websockets in url rewrite Signed-off-by: Jesse Haka <[email protected]> Co-authored-by: zirain <[email protected]> (cherry picked from commit 3d51933) Signed-off-by: Arko Dasgupta <[email protected]> * Set host for http health checker explicitly to avoid using the cluster name as host header for http health checking request. (#3057) * Set host for http health checker explictly to avoid using the cluster name as host header for http health checking request Signed-off-by: lemonlinger <[email protected]> * fix broken tests Signed-off-by: lemonlinger <[email protected]> * fix health-check test case in xds translation Signed-off-by: lemonlinger <[email protected]> * Simplify code and concise comments Signed-off-by: lemonlinger <[email protected]> --------- Signed-off-by: lemonlinger <[email protected]> (cherry picked from commit 8f450a9) Signed-off-by: Arko Dasgupta <[email protected]> * fix: do not create infra resources when missing translated listeners (#3043) * fix: do not create infra resources when missing translated listeners Signed-off-by: Karol Szwaj <[email protected]> * remove empty line Signed-off-by: Karol Szwaj <[email protected]> * skip infra creation on empty listeners and log it Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> (cherry picked from commit 36d7141) Signed-off-by: Arko Dasgupta <[email protected]> * Fix: double slashes in redirect URL (#2998) * fix: double trailing splashs in redirect URL Signed-off-by: huabing zhao <[email protected]> * add e2e tests Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: huabing zhao <[email protected]> * fix test Signed-off-by: huabing zhao <[email protected]> * fix test Signed-off-by: huabing zhao <[email protected]> * fix test Signed-off-by: huabing zhao <[email protected]> * fix test Signed-off-by: huabing zhao <[email protected]> * add e2e tests Signed-off-by: huabing zhao <[email protected]> * fix test Signed-off-by: huabing zhao <[email protected]> * revert Signed-off-by: huabing zhao <[email protected]> * use regex rewrite to generate the redirect url Signed-off-by: huabing zhao <[email protected]> * use regex rewrite to generate the redirect url Signed-off-by: huabing zhao <[email protected]> * use regex rewrite to generate the redirect url Signed-off-by: huabing zhao <[email protected]> * remove comments Signed-off-by: huabing zhao <[email protected]> * extract method Signed-off-by: huabing zhao <[email protected]> * address comments Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> (cherry picked from commit ceb697f) Signed-off-by: Arko Dasgupta <[email protected]> * fix: Allow Policy to attach to multiple http listeners (#2967) * Fixing the clienttrafficpolicy validation. Signed-off-by: Lior Okman <[email protected]> * Make SecurityPolicy validate correctly. Signed-off-by: Lior Okman <[email protected]> * Reverted the SecurityPolicy validation - handled differently via another feature. Signed-off-by: Lior Okman <[email protected]> * Updated the tests to reflect that this validation isn't required for SecurityPolicy Signed-off-by: Lior Okman <[email protected]> * Added some comments to explain the validation being performed. Signed-off-by: Lior Okman <[email protected]> * Updated the error message as requested in the review. Signed-off-by: Lior Okman <[email protected]> --------- Signed-off-by: Lior Okman <[email protected]> (cherry picked from commit f9409e4) Signed-off-by: Arko Dasgupta <[email protected]> * fix: set path prefix for http ext auth service (#3018) Signed-off-by: huabing zhao <[email protected]> (cherry picked from commit 2882b7c) Signed-off-by: Arko Dasgupta <[email protected]> * Change route sorting order to Exact > RegularExpression > PathPrefix (#2579) * Change route sorting order to Exact > RegularExpression > PathPrefix kubernetes-sigs/gateway-api#1770 kubernetes-sigs/gateway-api#1855 Signed-off-by: Stéphane Cottin <[email protected]> (cherry picked from commit 11f56fd) Signed-off-by: Arko Dasgupta <[email protected]> * fix: infraIR duplicate port translation for merged gateways (#3061) * fix: duplicate port translation for merged gateways Signed-off-by: Karol Szwaj <[email protected]> * refactor to map Signed-off-by: Karol Szwaj <[email protected]> * rename map Signed-off-by: Karol Szwaj <[email protected]> * add seperate testcase Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> (cherry picked from commit 29946b0) Signed-off-by: Arko Dasgupta <[email protected]> * translator: set SpawnUpstreamSpan to true (#3102) * translator: set SpawnUpstreamSpan to true Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 635ebfc) Signed-off-by: Arko Dasgupta <[email protected]> * fix: rate limit doesn't work with two(and more) listeners (#3085) * fix: rate limit doesn't work with two listeners Signed-off-by: huabing zhao <[email protected]> * add e2e test for rate limit on multiple listeners Signed-off-by: huabing zhao <[email protected]> * address comments Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> Co-authored-by: Xunzhuo <[email protected]> (cherry picked from commit a5bedbc) Signed-off-by: Arko Dasgupta <[email protected]> * rerun make testdata Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Jesse Haka <[email protected]> Signed-off-by: lemonlinger <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: Lior Okman <[email protected]> Signed-off-by: Stéphane Cottin <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> Co-authored-by: Jesse Haka <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Meng <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: Lior Okman <[email protected]> Co-authored-by: vixns <[email protected]> Co-authored-by: Xunzhuo <[email protected]>

run certgen when upgrading

6994bf7

Signed-off-by: huabing zhao <[email protected]>

zhaohuabing requested a review from a team as a code owner March 15, 2024 07:11

cnvergence approved these changes Mar 15, 2024

View reviewed changes

guydc approved these changes Mar 15, 2024

View reviewed changes

zirain approved these changes Mar 15, 2024

View reviewed changes

zirain merged commit 62ecf15 into envoyproxy:main Mar 15, 2024

arkodg added the cherrypick/release-v1.0 label Mar 15, 2024

arkodg mentioned this pull request Mar 15, 2024

Perform Helm Upgrade in E2E Upgrade Test #2941

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run certgen when upgrading#2934

Run certgen when upgrading#2934
zirain merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:run-certgen-when-upgrade

zhaohuabing commented Mar 15, 2024 •

edited

Loading

Uh oh!

codecov bot commented Mar 15, 2024

Uh oh!

zirain commented Mar 15, 2024

Uh oh!

zhaohuabing commented Mar 15, 2024

Uh oh!

zirain commented Mar 15, 2024 •

edited

Loading

Uh oh!

zhaohuabing commented Mar 15, 2024 •

edited

Loading

Uh oh!

zirain commented Mar 15, 2024

Uh oh!

guydc commented Mar 15, 2024 •

edited

Loading

Uh oh!

guydc commented Mar 15, 2024

Uh oh!

zhaohuabing commented Mar 15, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

zhaohuabing commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 15, 2024

Codecov Report

Uh oh!

zirain commented Mar 15, 2024

Uh oh!

zhaohuabing commented Mar 15, 2024

Uh oh!

zirain commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhaohuabing commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zirain commented Mar 15, 2024

Uh oh!

guydc commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guydc commented Mar 15, 2024

Uh oh!

zhaohuabing commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhaohuabing commented Mar 15, 2024 •

edited

Loading

zirain commented Mar 15, 2024 •

edited

Loading

zhaohuabing commented Mar 15, 2024 •

edited

Loading

guydc commented Mar 15, 2024 •

edited

Loading

zhaohuabing commented Mar 15, 2024 •

edited

Loading