e2e: backend upgrade test by guydc · Pull Request #2725 · envoyproxy/gateway

guydc · 2024-02-29T00:00:41Z

What this PR does / why we need it:
Tests backend upgrades - ensuring zero-downtime restarts of backend pods when retry and circuit breaker are configured.

Following discussion with @arkodg in the last community meeting, we will use fortio to generate a load. Rationale for using fortio over hey, vegeta, k6 and other golang load generators:

Apache-2.0 license
Relatively active and maintained project
Owned by the fortio org, rather than a specific contributor
Affinity to the Envoy project
Convenient reporting interface

Depends on: #2773 , #2754

Which issue(s) this PR fixes:
Fixes #1743

codecov · 2024-02-29T00:04:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.44%. Comparing base (26def5c) to head (1292269).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2725   +/-   ##
=======================================
  Coverage   63.44%   63.44%           
=======================================
  Files         125      125           
  Lines       20604    20604           
=======================================
  Hits        13073    13073           
  Misses       6693     6693           
  Partials      838      838

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

guydc · 2024-03-02T00:31:41Z

/retest

Signed-off-by: Guy Daich <[email protected]>

guydc · 2024-03-05T01:15:38Z

/retest

Xunzhuo

LGTM

test/e2e/tests/backend-upgrade.go

Signed-off-by: Guy Daich <[email protected]>

test/e2e/tests/backend-upgrade.go

guydc · 2024-03-05T13:00:35Z

/retest

guydc · 2024-03-05T13:17:49Z

/retest

guydc · 2024-03-05T14:14:38Z

/retest

arkodg · 2024-03-05T18:15:25Z

test/e2e/testdata/backend-upgrade.yaml

+    maxParallelRequests: 10000
+    maxConnections: 10000
+    maxPendingRequests: 10000
+  retry:


late to this party, should we recommend retryOn connection failure over outlier detection (passive health check) ?

late to this party, should we recommend retryOn connection failure over outlier detection (passive health check) ?

I think that outlier detection plays a role in more prolonged backend downtime scenarios, where backends are finally expected to recover and rejoin the loadbalancing pool. In this specific test:

rolling the deployment takes 1-2s

outliers will never rejoin the pool, as their ClusterIPs will be eliminated in the rolling process

When writing the tests, I saw the following envoy error codes:

UF: was mitigated with connect-failure trigger

UC: was mitigated with reset trigger

UO: was mitigated by increasing max_retries and using a strategy that redispatches retries to different hosts

I was hesitant to use the reset trigger in this example, as some of the reset situations are mid-response, e.g. upstream_reset_after_response_started. So, there's a concern that non-idempotent requests can be retried without knowing that their response code was retriable, which is unsafe. That's also why reset is not in the default trigger list, from my PoV.

Either way, if we want a test that demonstrates 100% success rate, I think that outlier detection alone would not be enough, as terminating pods would be ejected only after some requests already failed. The retry host selection predicate play a role similar to outlier detection in this example.

So, when using this sort of config, users should be aware of the risk, and they can decide wether they are willing to accept failure for some requests that were in-flight during the upgrade, or retry them at the risk of corrupting data at the backend.

I think that a more robust approach to ZDM on the backed would also require some work on the backend. Quite similar to what we did for EG's graceful shutdown:

Define a HC endpoint on the backend

Configure EG to probe the HC endpoint and setup EG upstream connection idle timeouts

Upon termination, backend starts failing the HC endpoint and gracefully draining connections

Envoy identifies that the terminating pods in unhealthy and stops creating new connections

idle timeouts kick-in on both sides and connections scale to 0

backend pod is terminated safely

thanks for writing out this detailed analysis !
would be great to convert some of this work into a user guide called - Backend Upgrades and share the retry logic and also highlight a better approach using active health checks

* ci: update cherry-pick v1.0.0 (#2784) Signed-off-by: bitliu <[email protected]> * fix: add missing release notes details and re organize it (#2785) fix: complete missing release notes and re organize it Signed-off-by: bitliu <[email protected]> * e2e: backend upgrade test (#2725) * chore: add testdata to passive health checks (#2788) * chore: add testdata to passive health checks Signed-off-by: yeedove <[email protected]> * fix test Signed-off-by: yeedove <[email protected]> --------- Signed-off-by: yeedove <[email protected]> * promote: guydc as maintainer (#2794) Signed-off-by: bitliu <[email protected]> * fix: Delete unused status keys from watchable (#2782) * Delete unused status keys in gatewayapi-runner Signed-off-by: Yuneui Jeong <[email protected]> * Delete unused status keys in xds-translator runner Signed-off-by: Yuneui Jeong <[email protected]> * Add tests and fix code to pass all tests Signed-off-by: Yuneui Jeong <[email protected]> * Cover more Signed-off-by: Yuneui <[email protected]> * Change struct's name and other minor fixes Signed-off-by: Yuneui Jeong <[email protected]> --------- Signed-off-by: Yuneui Jeong <[email protected]> Signed-off-by: Yuneui <[email protected]> * docs: fix commands in basic auth example (#2791) Signed-off-by: Arko Dasgupta <[email protected]> * feat: Support WellKnownSystemCerts in BackendTLSPolicy (#2804) * Add support for using the system truststore with upstream TLS. Signed-off-by: Lior Okman <[email protected]> * Make the linter happy Signed-off-by: Lior Okman <[email protected]> --------- Signed-off-by: Lior Okman <[email protected]> * docs: refactor user guides (#2797) * docs: refactor user guides Signed-off-by: bitliu <[email protected]> * fix: relative paths Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> * Fix gen check (#2814) * fix: gen-check error Signed-off-by: bitliu <[email protected]> * run lint for docs Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> * refactor: set instead of map for mergeGateways (#2803) * refactor:set[T] instead of map[T]bool Signed-off-by: Dennis Zhou <[email protected]> * fix lint Signed-off-by: Dennis Zhou <[email protected]> --------- Signed-off-by: Dennis Zhou <[email protected]> Co-authored-by: Xunzhuo <[email protected]> * remove: support for hostnetwork (#2815) * feat(egctl): add support for egctl to translate from gateway-api resources to IR (#2799) * Added an option to translate to IR representation. Signed-off-by: Lior Okman <[email protected]> * Added a unit test, and made sure that existing services have an IP address. Signed-off-by: Lior Okman <[email protected]> * Add omitempty where needed. Signed-off-by: Lior Okman <[email protected]> * Make gen-check happy Signed-off-by: Lior Okman <[email protected]> * Added some documentation. Signed-off-by: Lior Okman <[email protected]> --------- Signed-off-by: Lior Okman <[email protected]> * docs: basic auth example use https (#2806) * docs: basic auth example use https Signed-off-by: phantooom <[email protected]> * docs: refactor user guides (#2797) * docs: refactor user guides Signed-off-by: bitliu <[email protected]> * fix: relative paths Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> Signed-off-by: phantooom <[email protected]> * Fix gen check (#2814) * fix: gen-check error Signed-off-by: bitliu <[email protected]> * run lint for docs Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> Signed-off-by: phantooom <[email protected]> * refactor: set instead of map for mergeGateways (#2803) * refactor:set[T] instead of map[T]bool Signed-off-by: Dennis Zhou <[email protected]> * fix lint Signed-off-by: Dennis Zhou <[email protected]> --------- Signed-off-by: Dennis Zhou <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Signed-off-by: phantooom <[email protected]> * Update site/content/en/latest/user/security/basic-auth.md Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: zou rui <[email protected]> --------- Signed-off-by: phantooom <[email protected]> Signed-off-by: bitliu <[email protected]> Signed-off-by: Dennis Zhou <[email protected]> Signed-off-by: zou rui <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Dennis Zhou <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> * chore: group go.opentelemetry.io dependabot (#2821) Signed-off-by: zirain <[email protected]> * Add referenced BackendRefs for ExtAuth to Resource Tree (#2795) * add referenced BackendRefs for ExtAuth to Resource Tree Signed-off-by: huabing zhao <[email protected]> * clean up the controller code Signed-off-by: huabing zhao <[email protected]> * minor changes Signed-off-by: huabing zhao <[email protected]> * return errors Signed-off-by: huabing zhao <[email protected]> * fix validate error Signed-off-by: huabing zhao <[email protected]> * fix gen Signed-off-by: huabing zhao <[email protected]> * Support BackendTLSPolicy for the Ext HTTP/GRPC auth service Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: huabing zhao <[email protected]> * fix gen Signed-off-by: huabing zhao <[email protected]> * check cross-ns reference grant Signed-off-by: huabing zhao <[email protected]> * fix test Signed-off-by: huabing zhao <[email protected]> * fix test Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * fix bootstrap merge (#2801) * fix bootstrap merge Signed-off-by: zirain <[email protected]> * refactor validateBootstrap Signed-off-by: zirain <[email protected]> * lint Signed-off-by: zirain <[email protected]> * update test Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: skip the ReasonTargetNotFound for all policies (#2802) * stop populating ReasonTargetNotFound for all the policies Signed-off-by: shawnh2 <[email protected]> * add test to ensure the status is expected Signed-off-by: shawnh2 <[email protected]> * fix gen-check and lint Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> * docs: update EnvoyProxy logs (#2822) * docs: update EnvoyProxy logs Signed-off-by: zirain <[email protected]> * lint Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: omit default replicas on Kubernetes Deployment (#2816) * fix: remove default replicas function Signed-off-by: Ardika Bagus <[email protected]> * chore: omit replicas because nil equal to 1 by default Signed-off-by: Ardika Bagus <[email protected]> * chore: add a note when a user is being explicit on deployment replicas Signed-off-by: Ardika Bagus <[email protected]> --------- Signed-off-by: Ardika Bagus <[email protected]> * bug: compute endpointType for all protocol types (#2833) Fixes: #2832 Signed-off-by: Arko Dasgupta <[email protected]> * docs: Routing outside k8s (#2831) * docs: Routing outside k8s Fixes: #2482 Signed-off-by: Arko Dasgupta <[email protected]> * updates Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> * build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#2825) Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump golang.org/x/net from 0.21.0 to 0.22.0 (#2826) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.21.0 to 0.22.0. - [Commits](golang/net@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#2827) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: failed to create envoy-oidc-hmac secret when upgrading EG (#2835) try to create every secret instead of returning eraly Signed-off-by: huabing zhao <[email protected]> * build(deps): bump google.golang.org/grpc from 1.62.0 to 1.62.1 (#2829) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.0 to 1.62.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.62.0...v1.62.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Ext auth e2e tests (#2830) * e2e tests for http ext auth Signed-off-by: huabing zhao <[email protected]> * export util methods to avoid unparam link issues Signed-off-by: huabing zhao <[email protected]> * fixt test Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> * fix existing secret check (#2838) fix existing secret Signed-off-by: zirain <[email protected]> * ci: update k8s matrix (#2836) * ci: update k8s matrix Signed-off-by: zirain <[email protected]> * v1.26.14 Signed-off-by: zirain <[email protected]> * nit Signed-off-by: zirain <[email protected]> * update matrix Signed-off-by: zirain <[email protected]> * link in quickstart Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> * 1.29.2 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * e2e: try to fix client timeout flakes (#2812) * chore: client timeout log Signed-off-by: zirain <[email protected]> * add EnvoyProxy extra args Signed-off-by: zirain <[email protected]> * add E2E_CLEANUP Signed-off-by: zirain <[email protected]> * nit Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * feat: Support Upstream TLS to multiple Backends (#2818) * Use transport_socket_matches to setup correct sockets for different destinations. Signed-off-by: Lior Okman <[email protected]> * Support Proxy Protocol for TLS upstreams. Signed-off-by: Lior Okman <[email protected]> * Changed the name generated for each transport match to be more inline with other names used in other places in xDS. Signed-off-by: Lior Okman <[email protected]> * Added one more case in the unit-test to show that upstream proxy-protocol still works. Signed-off-by: Lior Okman <[email protected]> --------- Signed-off-by: Lior Okman <[email protected]> * e2e: move drain settings into shutdown settings (#2850) Signed-off-by: Arko Dasgupta <[email protected]> * docs: mtls to the gateway (#2851) * docs: mtls to the gateway Signed-off-by: Arko Dasgupta <[email protected]> * edits Signed-off-by: Arko Dasgupta <[email protected]> * add ref Signed-off-by: Arko Dasgupta <[email protected]> * typo Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> * ignore finalizers when comparing envoy proxy svc (#2856) * ignore finalizers when comparing envoy proxy svc Fixes: #1820 Signed-off-by: Arko Dasgupta <[email protected]> * Chore: remove the uncessary allAssociatedRefGrants from resourceMappings (#2843) * modify oidc docs Signed-off-by: huabing zhao <[email protected]> * clear allAssociatedRefGrants Signed-off-by: huabing zhao <[email protected]> * address comments Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * docs: allow users to configure custom certs for control plane auth (#2847) Signed-off-by: zirain <[email protected]> * add e2e tests for ext auth with grpc auth service (#2841) * add e2e tests for ext auth with grpc auth service Signed-off-by: huabing zhao <[email protected]> * add BackedTLSPolicy Signed-off-by: huabing zhao <[email protected]> * generate TLS socket for ext auth services Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * fix: Address race condition disrupting graceful shutdown process (#2864) Signed-off-by: David Alger <[email protected]> * docs: move Design docs under "Get Involved" (#2857) * docs: move Design docs under "Get Involved" * design docs are more relevant to internal contributors than external users Signed-off-by: Arko Dasgupta <[email protected]> * fix links Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> * e2e: backend TLS policy (#2853) * start backendtls test Signed-off-by: Guy Daich <[email protected]> * fix lint Signed-off-by: Guy Daich <[email protected]> * use better name for egSetup(...) Signed-off-by: Guy Daich <[email protected]> * add negative test Signed-off-by: Guy Daich <[email protected]> * use static certs for test Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> * Update the user doc for OIDC (#2778) * user doc for oidc Signed-off-by: huabing zhao <[email protected]> * address comments Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * add ADOPTERS.md (#2865) ADOPTERS.md Signed-off-by: huabing zhao <[email protected]> Co-authored-by: Xunzhuo <[email protected]> * build(deps): bump softprops/action-gh-release from 1 to 2 (#2867) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@de2c0eb...d99959e) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/bufbuild/buf from 1.29.0 to 1.30.0 in /tools/src/buf (#2870) build(deps): bump github.com/bufbuild/buf in /tools/src/buf Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.29.0 to 1.30.0. - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.29.0...v1.30.0) --- updated-dependencies: - dependency-name: github.com/bufbuild/buf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/prometheus/common from 0.49.0 to 0.50.0 (#2871) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.49.0 to 0.50.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.49.0...v0.50.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump fortio.org/fortio from 1.63.3 to 1.63.4 (#2873) Bumps [fortio.org/fortio](https://github.com/fortio/fortio) from 1.63.3 to 1.63.4. - [Release notes](https://github.com/fortio/fortio/releases) - [Commits](fortio/fortio@v1.63.3...v1.63.4) --- updated-dependencies: - dependency-name: fortio.org/fortio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add tetrate to adopters (#2874) add tetrate to adopters Signed-off-by: huabing zhao <[email protected]> * fix: Don't override the ALPN array if HTTP/3 is enabled. (#2876) * Don't override the ALPN array if HTTP/3 is enabled. Signed-off-by: Lior Okman <[email protected]> * Removed the unneeded CEL validation for HTTP/3 and ALPN, as well as the CEL tests. Signed-off-by: Lior Okman <[email protected]> * Also regenerate the CRD. Signed-off-by: Lior Okman <[email protected]> --------- Signed-off-by: Lior Okman <[email protected]> * [e2e] eg release upgrade test (#2862) * [e2e] eg release upgrade test Signed-off-by: Alexander Volchok <[email protected]> * fixing linit Signed-off-by: Alexander Volchok <[email protected]> * Update test/e2e/tests/eg_upgrade.go Co-authored-by: zirain <[email protected]> Signed-off-by: Alex Volchok <[email protected]> * Update test/e2e/tests/eg_upgrade.go Co-authored-by: zirain <[email protected]> Signed-off-by: Alex Volchok <[email protected]> * adding updated go mod Signed-off-by: Alexander Volchok <[email protected]> * fix tests Signed-off-by: Alexander Volchok <[email protected]> * move eg upgrade tests to a dedicated suit Signed-off-by: Alexander Volchok <[email protected]> * removing unused Signed-off-by: Alexander Volchok <[email protected]> * fix code review feedbacks and move e2e clean after the eg upgrades suit Signed-off-by: Alexander Volchok <[email protected]> * don't clean after this step yet Signed-off-by: Alexander Volchok <[email protected]> * increase helm install / upgrade default timeouts Signed-off-by: Alexander Volchok <[email protected]> * restructure test order add an option to execute a single test Signed-off-by: Alexander Volchok <[email protected]> * fix kube make single test exec Signed-off-by: Alexander Volchok <[email protected]> * change to rc version Signed-off-by: Alexander Volchok <[email protected]> * removing loadtest part, changing to simple requests Signed-off-by: Alexander Volchok <[email protected]> --------- Signed-off-by: Alexander Volchok <[email protected]> Signed-off-by: Alex Volchok <[email protected]> Co-authored-by: zirain <[email protected]> * Docs for ext auth (#2868) * docs for ext auth Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * Remove the uncessary \ (#2883) remove the \ Signed-off-by: huabing zhao <[email protected]> * docs: backend tls policy (#2884) * backend tls docs Signed-off-by: Guy Daich <[email protected]> * fix somy copy-paste mistakes Signed-off-by: Guy Daich <[email protected]> * fix typo Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> * feat: add PolicyStatus for BackendTrafficPolicy (#2846) * add PolicyStatus for BTP Signed-off-by: shawnh2 <[email protected]> * fix gen-check Signed-off-by: shawnh2 <[email protected]> * fix ns problem, add more test and modify controller behavior Signed-off-by: shawnh2 <[email protected]> * fix lint Signed-off-by: shawnh2 <[email protected]> * make gateway as the ancestor of btp if it is targeting to the gateway Signed-off-by: shawnh2 <[email protected]> * fix linter Signed-off-by: shawnh2 <[email protected]> * fix go.mod Signed-off-by: shawnh2 <[email protected]> * do some polish Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> * Change the Merge behavior to Replace for SecurityPolicy (#2885) * Change the Merge behavior to Replace for SecurityPolicy Signed-off-by: huabing zhao <[email protected]> * add another http route Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * e2e: add weighted backend (#2863) * e2e: add backend weighted Signed-off-by: ShyunnY <[email protected]> * fix: Fix weight calculation issue and use AlmostEqual func Signed-off-by: ShyunnY <[email protected]> * fix: add additional comments Signed-off-by: ShyunnY <[email protected]> --------- Signed-off-by: ShyunnY <[email protected]> Co-authored-by: Xunzhuo <[email protected]> * http3: use service port in alt-svc header (#2886) Fixes: #2882 Signed-off-by: Arko Dasgupta <[email protected]> * bug: add h3 alpn by default if http3 is enabled (#2887) Fixes: #2875 Signed-off-by: Arko Dasgupta <[email protected]> * fix: prevent policies targeting non-TLS listeners on the same port from conflicting (#2786) * * Validate that multiple policies that affect listener configuration don't map to the same listener filter chain. * Change the XDS listener generation so that instead of defaultFilterChain for non-TLS routes, a filterChain with a destinationPort matcher is used. This allows multiple policies attached to non-TLS listeners that differ on the destination port to provide different policies without conflicting. Signed-off-by: Lior Okman <[email protected]> * Make hostname based routing work again for non-TLS listeners Signed-off-by: Lior Okman <[email protected]> * Fixed testdata for egctl Signed-off-by: Lior Okman <[email protected]> * Make the linter happy Signed-off-by: Lior Okman <[email protected]> * Added a unit-test Signed-off-by: Lior Okman <[email protected]> * Make the linter happy Signed-off-by: Lior Okman <[email protected]> * Update an e2e test with the new filterChain patch Signed-off-by: Lior Okman <[email protected]> * Revert changing the XDS translation, since a new listener is created anyways for each port. Signed-off-by: Lior Okman <[email protected]> * Also revert the xds change in the e2e test. Signed-off-by: Lior Okman <[email protected]> * Don't need to go over the full XDSIR map - just the current gateway. Signed-off-by: Lior Okman <[email protected]> * Refactored to separate the validation and the translation. Renamed the helper method to a more generic name. Signed-off-by: Lior Okman <[email protected]> --------- Signed-off-by: Lior Okman <[email protected]> Co-authored-by: Guy Daich <[email protected]> * chore: remove ProcessBackendTLSPoliciesAncestorRef (#2845) * remove ProcessBackendTLSPoliciesAncestorRef Signed-off-by: huabing zhao <[email protected]> * address comments Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * Change the Merge behavior to Replace for BackendTrafficPolicy (#2888) * Change the Merge behavior to Replace for BackendTrafficPolicy Signed-off-by: huabing zhao <[email protected]> * address comments Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> * shutdown drainTimeout should also affect envoy drain time (#2898) Signed-off-by: Arko Dasgupta <[email protected]> * skip publishing empty status for policies (#2902) * skip publishing empty status for policies * #2802 skips computing status if a target resource cannot be found, mainly because that target maybe irrelevant to this specific translation, its hard to proactively find that out in the provider layer * This fix ensures that any empty status is not published and resets any existing status for a policy Signed-off-by: Arko Dasgupta <[email protected]> * also fix for envoypatchpolicy Signed-off-by: Arko Dasgupta <[email protected]> * also discard status for backendtlspolicy Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> * docs: multiple gatewayclass and merge gateways deployment mode (#2881) * docs: multiple gatewayclass and merge gateways deployment mode Signed-off-by: Karol Szwaj <[email protected]> * add merged-gateways example Signed-off-by: Karol Szwaj <[email protected]> * md lint Signed-off-by: Karol Szwaj <[email protected]> * yaml lint Signed-off-by: Karol Szwaj <[email protected]> * add user guides Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: Xunzhuo <[email protected]> * feat: add PolicyStatus for ClientTrafficPolicy (#2895) * add PolicyStatus for CTP Signed-off-by: shawnh2 <[email protected]> * fix gen-check Signed-off-by: shawnh2 <[email protected]> * revert discard policy status Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> * Use gwapiv1a2.PolicyStatus for SecurityPolicy Status (#2848) * use gwapiv1a2.PolicyStatus for SecurityPolicy Status Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: huabing zhao <[email protected]> * add test for cross-ns refs Signed-off-by: huabing zhao <[email protected]> * add todo Signed-off-by: huabing zhao <[email protected]> * Update internal/gatewayapi/securitypolicy.go Co-authored-by: sh2 <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> * address comments Signed-off-by: huabing zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: sh2 <[email protected]> * Fix oidc doc (#2905) fix oidc doc Signed-off-by: huabing zhao <[email protected]> * Release v1.0 (#2909) * add v1.0.0 release note Signed-off-by: bitliu <[email protected]> * generate v1.0 release page Signed-off-by: bitliu <[email protected]> * add v1.0.0 release announcement Signed-off-by: bitliu <[email protected]> * generate v1.0.0 docs Signed-off-by: bitliu <[email protected]> * update site links Signed-off-by: bitliu <[email protected]> * fix linter Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> Signed-off-by: yeedove <[email protected]> Signed-off-by: Yuneui Jeong <[email protected]> Signed-off-by: Yuneui <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Lior Okman <[email protected]> Signed-off-by: Dennis Zhou <[email protected]> Signed-off-by: phantooom <[email protected]> Signed-off-by: zou rui <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: huabing zhao <[email protected]> Signed-off-by: shawnh2 <[email protected]> Signed-off-by: Ardika Bagus <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: David Alger <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Alexander Volchok <[email protected]> Signed-off-by: Alex Volchok <[email protected]> Signed-off-by: ShyunnY <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Dennis Zhou <[email protected]> Co-authored-by: Yuneui Jeong <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Lior Okman <[email protected]> Co-authored-by: Dennis Zhou <[email protected]> Co-authored-by: zou rui <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: sh2 <[email protected]> Co-authored-by: Ardika <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Alger <[email protected]> Co-authored-by: Alex Volchok <[email protected]> Co-authored-by: Shyunn <[email protected]> Co-authored-by: Karol Szwaj <[email protected]>

guydc force-pushed the test-backend-upgrades branch from ea37b23 to bc972f1 Compare February 29, 2024 00:01

guydc changed the title ~~[WIP]chore: backend upgrade test~~ [WIP]e2e: backend upgrade test Feb 29, 2024

guydc force-pushed the test-backend-upgrades branch 3 times, most recently from 4218492 to 543b266 Compare March 1, 2024 23:29

This was referenced Mar 2, 2024

Find the right home for maximum number of parallel retries #2322

Closed

set a default retry budget and host retry predicate #2754

Closed

guydc force-pushed the test-backend-upgrades branch from 543b266 to e2b532a Compare March 4, 2024 23:55

backend upgrade test

c332805

Signed-off-by: Guy Daich <[email protected]>

guydc force-pushed the test-backend-upgrades branch from e2b532a to c332805 Compare March 5, 2024 00:00

guydc marked this pull request as ready for review March 5, 2024 00:00

guydc requested a review from a team as a code owner March 5, 2024 00:00

guydc changed the title ~~[WIP]e2e: backend upgrade test~~ e2e: backend upgrade test Mar 5, 2024

Merge branch 'main' into test-backend-upgrades

8fcb944

guydc added the road-to-ga label Mar 5, 2024

Xunzhuo previously approved these changes Mar 5, 2024

View reviewed changes

zirain reviewed Mar 5, 2024

View reviewed changes

test/e2e/tests/backend-upgrade.go Outdated Show resolved Hide resolved

use timeoutconfig, remove sleep

2f9be9e

Signed-off-by: Guy Daich <[email protected]>

guydc dismissed Xunzhuo’s stale review via 2f9be9e March 5, 2024 12:14

guydc added 3 commits March 5, 2024 06:17

fix

e141e19

Signed-off-by: Guy Daich <[email protected]>

Merge branch 'main' into test-backend-upgrades

e9638cb

fix lint

1292269

Signed-off-by: Guy Daich <[email protected]>

zirain reviewed Mar 5, 2024

View reviewed changes

test/e2e/tests/backend-upgrade.go Show resolved Hide resolved

zirain reviewed Mar 5, 2024

View reviewed changes

test/e2e/tests/backend-upgrade.go Show resolved Hide resolved

zirain approved these changes Mar 5, 2024

View reviewed changes

Xunzhuo approved these changes Mar 5, 2024

View reviewed changes

Xunzhuo merged commit 8817d4e into envoyproxy:main Mar 5, 2024

arkodg reviewed Mar 5, 2024

View reviewed changes

Xunzhuo pushed a commit to Xunzhuo/gateway that referenced this pull request Mar 13, 2024

e2e: backend upgrade test (envoyproxy#2725)

aebf682

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

e2e: backend upgrade test#2725

e2e: backend upgrade test#2725
Xunzhuo merged 6 commits intoenvoyproxy:mainfrom
guydc:test-backend-upgrades

guydc commented Feb 29, 2024 •

edited

Loading

Uh oh!

codecov bot commented Feb 29, 2024 •

edited

Loading

Uh oh!

guydc commented Mar 2, 2024

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

Xunzhuo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

arkodg Mar 5, 2024

Uh oh!

guydc Mar 5, 2024 •

edited

Loading

Uh oh!

arkodg Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

guydc commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

guydc commented Mar 2, 2024

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

Xunzhuo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

guydc commented Mar 5, 2024

Uh oh!

arkodg Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

guydc Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkodg Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guydc commented Feb 29, 2024 •

edited

Loading

codecov bot commented Feb 29, 2024 •

edited

Loading

guydc Mar 5, 2024 •

edited

Loading