Skip to content

Adds HTTPRoute BackendRefs to Resource Map#270

Merged
danehans merged 1 commit intoenvoyproxy:mainfrom
danehans:svc_res_map
Aug 30, 2022
Merged

Adds HTTPRoute BackendRefs to Resource Map#270
danehans merged 1 commit intoenvoyproxy:mainfrom
danehans:svc_res_map

Conversation

@danehans
Copy link
Copy Markdown
Contributor

@danehans danehans commented Aug 28, 2022

Adds HTTPRoute backendRefs to the watchable resource map.

  • Adds backendRef validation to HTTPRoute controller. Note that only local Service object references are supported.
  • Adds valid backendRefs to the watchable resource map.
  • Updates Kube integration tests to ensure that valid backendRefs are added to the watchable resource map.
  • Adds backendRefs, e.g. Services, to the gatewayapi runner.
  • Adds Services object type to ProviderResources and updates unit tests accordingly.

Fixes: #189

Signed-off-by: danehans [email protected]

@danehans danehans requested a review from a team as a code owner August 28, 2022 23:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #270 (6dc821e) into main (d3c041f) will decrease coverage by 0.37%.
The diff coverage is 54.16%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   58.45%   58.08%   -0.38%     
==========================================
  Files          31       31              
  Lines        2773     2820      +47     
==========================================
+ Hits         1621     1638      +17     
- Misses       1058     1085      +27     
- Partials       94       97       +3
Impacted Files Coverage Δ
internal/provider/kubernetes/httproute.go 62.00% <43.58%> (-6.75%) ⬇️
internal/message/types.go 100.00% <100.00%> (ø)
internal/provider/kubernetes/gateway.go 77.04% <0.00%> (-6.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

arkodg
arkodg reviewed Aug 29, 2022
View reviewed changes
@zirain
Copy link
Copy Markdown
Member

zirain commented Aug 30, 2022

ping @arkodg please Merge this to main

@danehans danehans merged commit 82408b8 into envoyproxy:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Service Watch to HTTPRoute Controller

4 participants

@danehans @codecov-commenter @zirain @arkodg