Skip to content

feat(translator): Implement BTP TCPKeepAlive#2581

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
guydc:impl-btp-ka
Feb 12, 2024
Merged

feat(translator): Implement BTP TCPKeepAlive#2581
arkodg merged 2 commits intoenvoyproxy:mainfrom
guydc:impl-btp-ka

Conversation

@guydc
Copy link
Copy Markdown
Contributor

@guydc guydc commented Feb 9, 2024

What this PR does / why we need it:
Implements upstream TCP keep alive API in BakcendTrafficPolicy.

Which issue(s) this PR fixes:
Fixes #1031

@guydc guydc requested a review from a team as a code owner February 9, 2024 14:25
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (bb59484) 64.06% compared to head (050328a) 64.09%.

Files Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 77.77% 6 Missing and 2 partials ⚠️
internal/ir/zz_generated.deepcopy.go 0.00% 4 Missing and 1 partial ⚠️
internal/xds/translator/cluster.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
+ Coverage   64.06%   64.09%   +0.03%     
==========================================
  Files         119      119              
  Lines       18640    18703      +63     
==========================================
+ Hits        11941    11988      +47     
- Misses       5915     5927      +12     
- Partials      784      788       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Feb 9, 2024
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team February 9, 2024 18:53
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guydc
Copy link
Copy Markdown
Contributor Author

guydc commented Feb 12, 2024

/retest

1 similar comment
@guydc
Copy link
Copy Markdown
Contributor Author

guydc commented Feb 12, 2024

/retest

@arkodg arkodg merged commit 2c1b946 into envoyproxy:main Feb 12, 2024
arkodg pushed a commit to arkodg/gateway that referenced this pull request Feb 13, 2024
Between envoyproxy#2585
&
envoyproxy#2581

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg mentioned this pull request Feb 13, 2024
arkodg added a commit that referenced this pull request Feb 13, 2024
Between #2585
&
#2581

Signed-off-by: Arko Dasgupta <[email protected]>
yaelSchechter pushed a commit to yaelSchechter/envoy-gateway that referenced this pull request Feb 14, 2024
Between envoyproxy#2585
&
envoyproxy#2581

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
zirain added a commit that referenced this pull request Feb 18, 2024
* feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default (#2585)

* Implement and update tests for the default header transformations.

Signed-off-by: Lior Okman <[email protected]>

* Make 'gen-check' happy

Signed-off-by: Lior Okman <[email protected]>

---------

Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* bug: fix merge race (#2604)

Between #2585
&
#2581

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat: downstream mTLS (#2490)

* feat: downstream mTLS

Relates to #2483

Signed-off-by: Arko Dasgupta <[email protected]>

* configmap provider logic

Signed-off-by: Arko Dasgupta <[email protected]>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <[email protected]>

* fix charts

Signed-off-by: Arko Dasgupta <[email protected]>

* tests

Signed-off-by: Arko Dasgupta <[email protected]>

* lint

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* add timeout to clientTrafficPolicy

Signed-off-by: Yael Shechter <[email protected]>

* fix comment

Signed-off-by: Yael Shechter <[email protected]>

* add omitempty

Signed-off-by: Yael Shechter <[email protected]>

* add cel test for coverage

Signed-off-by: Yael Shechter <[email protected]>

* run make commands

Signed-off-by: Yael Shechter <[email protected]>

* change request timeout field name and desc

Signed-off-by: Yael Shechter <[email protected]>

* tidy up comment

Signed-off-by: Yael Shechter <[email protected]>

* fix cel test

Signed-off-by: Yael Shechter <[email protected]>

* fix typo

Signed-off-by: Yael Shechter <[email protected]>

* run generate

Signed-off-by: Yael Shechter <[email protected]>

---------

Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Co-authored-by: Lior Okman <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: zirain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeepAlive support

3 participants