feat: add Chinese language support for doc site by wilsonwu · Pull Request #2532 · envoyproxy/gateway

wilsonwu · 2024-01-29T04:54:04Z

What type of PR is this?
feat: add Chinese language support for doc site

All local test for compitibility with current English content, by default all contents are English without any URL change.

After change language, the URL will changed to [domain]/zh/[path] and just translate some of content for example, need more contributter for the translation.

What this PR does / why we need it:
To help Chinese users to learn and use Envoy Gateway easily

Which issue(s) this PR fixes:

Fixes #2012

wilsonwu · 2024-01-29T04:55:31Z

@Xunzhuo please help to review, and let's work on it together!

codecov · 2024-01-29T05:43:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.64%. Comparing base (2882b7c) to head (abf2a56).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
+ Coverage   64.62%   64.64%   +0.01%     
==========================================
  Files         121      121              
  Lines       21135    21135              
==========================================
+ Hits        13658    13662       +4     
+ Misses       6627     6625       -2     
+ Partials      850      848       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Xunzhuo · 2024-02-23T03:37:33Z

Thanks @wilsonwu, let us kick this off after GA.

wilsonwu · 2024-03-15T02:45:49Z

Congrats the 1.0 GA, let consider the Chinese version doc site, currently no good gateway product doc site support Chinese, I think this is a good opportunity for Envoy Gateway market share.

zhaohuabing

This PR looks good! Just a few minor nits :-)

site/content/zh/_index.md

site/content/zh/about/index.md

site/content/zh/latest/_index.md

site/content/zh/v0.6.0/_index.md

site/hugo.toml

wilsonwu · 2024-03-15T07:27:09Z

This PR looks good! Just a few minor nits :-)

Thanks for the review, more i18n contents will coming after this PR done.

zirain · 2024-03-15T07:42:07Z

I'd like focus on just the latest version, because it's almost WIP.

zhaohuabing

@wilsonwu This PR looks good. Could you please remove the v0.0.6 docs as @zirain suggested? Then we can merge it and start the Chinese docs work.

Thansk!

Signed-off-by: Wilson Wu <[email protected]>

Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Wilson Wu <[email protected]>

Signed-off-by: Wilson Wu <[email protected]>

wilsonwu · 2024-03-19T06:14:42Z

@wilsonwu This PR looks good. Could you please remove the v0.0.6 docs as @zirain suggested? Then we can merge it and start the Chinese docs work.

Thansk!

Done, thanks @zhaohuabing and @zirain

zhaohuabing

LGTM

Signed-off-by: Wilson Wu <[email protected]>

wilsonwu · 2024-03-19T10:30:06Z

Member

Thanks for reminder, all work fine in local.

site/hugo.toml

site/content/zh/_index.md

Signed-off-by: Wilson Wu <[email protected]>

zirain · 2024-03-20T07:07:26Z

sorry, I want to hold these before we fix all the dead links on the english site.

wilsonwu · 2024-03-20T10:11:24Z

sorry, I want to hold these before we fix all the dead links on the english site.

No problem, let me know if I can help on anything.

zhaohuabing

We can move on now since dead links have been solved.

Signed-off-by: Wilson Wu <[email protected]>

wilsonwu · 2024-03-24T14:25:01Z

We can move on now since dead links have been solved.

Thanks for the reminder, fixed a broken link.

Signed-off-by: Wilson Wu <[email protected]>

wilsonwu · 2024-03-25T03:23:17Z

There is still one broken link left:

And I submitted an issue for it #3005, I think it is not block for this PR.

* Add Chinese support for doc site Signed-off-by: Wilson Wu <[email protected]> * Add zh i18n for menus Signed-off-by: Wilson Wu <[email protected]> * Add zh content placeholders Signed-off-by: Wilson Wu <[email protected]> * Fix about zh page Signed-off-by: Wilson Wu <[email protected]> * Apply suggestions from code review Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Wilson Wu <[email protected]> * docs: `%s/Application/API/g` (envoyproxy#2929) Signed-off-by: Wilson Wu <[email protected]> * remove old version for zh content Signed-off-by: Wilson Wu <[email protected]> * Update the latest version link Signed-off-by: Wilson Wu <[email protected]> * Fix default content dir Signed-off-by: Wilson Wu <[email protected]> * Translate landing page and fix broken link Signed-off-by: Wilson Wu <[email protected]> * Fix broken link Signed-off-by: Wilson Wu <[email protected]> * Add a contribution page Signed-off-by: Wilson Wu <[email protected]> --------- Signed-off-by: Wilson Wu <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]>

* build(deps): bump github.com/prometheus/common from 0.50.0 to 0.51.1 (#3010) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.50.0 to 0.51.1. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.50.0...v0.51.1) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * docs: fix squash link (#3013) Signed-off-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * api: support IdleTimeout in clientTrafficPolicy Signed-off-by: Yael Shechter <[email protected]> * build(deps): bump fortio.org/fortio from 1.63.4 to 1.63.5 (#3011) Bumps [fortio.org/fortio](https://github.com/fortio/fortio) from 1.63.4 to 1.63.5. - [Release notes](https://github.com/fortio/fortio/releases) - [Commits](fortio/fortio@v1.63.4...v1.63.5) --- updated-dependencies: - dependency-name: fortio.org/fortio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * ci: trigger docs action (#3017) Signed-off-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * ci: fix cherrypick permission (#2985) Signed-off-by: zirain <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * fix: set path prefix for http ext auth service (#3018) Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * feat: add Chinese language support for doc site (#2532) * Add Chinese support for doc site Signed-off-by: Wilson Wu <[email protected]> * Add zh i18n for menus Signed-off-by: Wilson Wu <[email protected]> * Add zh content placeholders Signed-off-by: Wilson Wu <[email protected]> * Fix about zh page Signed-off-by: Wilson Wu <[email protected]> * Apply suggestions from code review Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Wilson Wu <[email protected]> * docs: `%s/Application/API/g` (#2929) Signed-off-by: Wilson Wu <[email protected]> * remove old version for zh content Signed-off-by: Wilson Wu <[email protected]> * Update the latest version link Signed-off-by: Wilson Wu <[email protected]> * Fix default content dir Signed-off-by: Wilson Wu <[email protected]> * Translate landing page and fix broken link Signed-off-by: Wilson Wu <[email protected]> * Fix broken link Signed-off-by: Wilson Wu <[email protected]> * Add a contribution page Signed-off-by: Wilson Wu <[email protected]> --------- Signed-off-by: Wilson Wu <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * feat(translator): implement connection limit (#2952) * implement connection limit Signed-off-by: Guy Daich <[email protected]> * fix lint Signed-off-by: Guy Daich <[email protected]> * fix lint 2 Signed-off-by: Guy Daich <[email protected]> * fix ir, coverage Signed-off-by: Guy Daich <[email protected]> * fix lint 3 Signed-off-by: Guy Daich <[email protected]> * open more connection in e2e Signed-off-by: Guy Daich <[email protected]> * fix error type Signed-off-by: Guy Daich <[email protected]> * add additional connections Signed-off-by: Guy Daich <[email protected]> * make limit value required Signed-off-by: Guy Daich <[email protected]> * add error-flow unit test Signed-off-by: Guy Daich <[email protected]> * fix lint 4 Signed-off-by: Guy Daich <[email protected]> * assert policy accepted in test Signed-off-by: Guy Daich <[email protected]> * rename limit => connectionLimit Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * docs: remove 0.1.0 from linkinator ignore list (#3015) Signed-off-by: yuluo <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * disable connection limit test (#3025) Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * fix: use correct connection limit attribute name in e2e, docs (#3028) fix attribute name Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * docs: document patches in envoy proxy (#3027) * docs: document patches in envoy proxy Signed-off-by: Yael Shechter <[email protected]> * fix linting issue Signed-off-by: Yael Shechter <[email protected]> * fix pr comment Signed-off-by: Yael Shechter <[email protected]> --------- Signed-off-by: Yael Shechter <[email protected]> * feat(policy): Adding BTP support for UDP/TCPRoute (#3004) * Adding BTP support for UDP/TCP Routes Signed-off-by: Alexander Volchok <[email protected]> * fixining lint Signed-off-by: Alexander Volchok <[email protected]> * fix IdleTime check Signed-off-by: Alexander Volchok <[email protected]> * adding missing generates Signed-off-by: Alexander Volchok <[email protected]> * fixing code review comments Signed-off-by: Alexander Volchok <[email protected]> * incresing code coverage Signed-off-by: Alexander Volchok <[email protected]> --------- Signed-off-by: Alexander Volchok <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * fix: add missing http filters to the http filter chain (#2970) * fix: add missing http filters to the http filter chain Signed-off-by: huabing zhao <[email protected]> * refactor Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: huabing zhao <[email protected]> * add comments Signed-off-by: huabing zhao <[email protected]> * remove refactor Signed-off-by: huabing zhao <[email protected]> * remove refactor Signed-off-by: huabing zhao <[email protected]> * fix gen Signed-off-by: huabing zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * fix pr comment Signed-off-by: Yael Shechter <[email protected]> * ci: grant pull-requests permission to cherrypick action (#3039) Signed-off-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * Update ADOPTERS.md for Airspace Link (#3045) Signed-off-by: Fabrice Aneche <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * feat: added option to specify resources on the OIDC security policy (#3030) added option to specify resources on the OIDC filter Signed-off-by: jaynis <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Yael Shechter <[email protected]> * run make commands Signed-off-by: Yael Shechter <[email protected]> * fix: allow websockets in url rewrite (#3022) allow websockets in url rewrite Signed-off-by: Jesse Haka <[email protected]> Co-authored-by: zirain <[email protected]> Signed-off-by: Yael Shechter <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Yael Shechter <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: huabing zhao <[email protected]> Signed-off-by: Wilson Wu <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: yuluo <[email protected]> Signed-off-by: Alexander Volchok <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Fabrice Aneche <[email protected]> Signed-off-by: jaynis <[email protected]> Signed-off-by: Jesse Haka <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Wilson Wu <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: YuLuo <[email protected]> Co-authored-by: Alex Volchok <[email protected]> Co-authored-by: Fabrice Aneche <[email protected]> Co-authored-by: jaynis <[email protected]> Co-authored-by: Jesse Haka <[email protected]>

wilsonwu requested a review from a team as a code owner January 29, 2024 04:54

wilsonwu force-pushed the zh-content-init branch from e280719 to 6400196 Compare January 29, 2024 04:54

wilsonwu force-pushed the zh-content-init branch 2 times, most recently from d28c63f to 15c4dcf Compare January 29, 2024 08:02

arkodg requested review from Xunzhuo, zhaohuabing and zirain January 29, 2024 17:37

Xunzhuo added the priority/low Label used to express the "low" priority level label Feb 23, 2024

arkodg added this to the Backlog milestone Feb 23, 2024

wilsonwu force-pushed the zh-content-init branch from 15c4dcf to 16d9758 Compare March 15, 2024 02:43

zhaohuabing reviewed Mar 15, 2024

View reviewed changes

zhaohuabing reviewed Mar 19, 2024

View reviewed changes

wilsonwu force-pushed the zh-content-init branch from 043bdce to 5168c90 Compare March 19, 2024 06:12

wilsonwu and others added 7 commits March 19, 2024 14:13

Add Chinese support for doc site

0998f90

Signed-off-by: Wilson Wu <[email protected]>

Add zh i18n for menus

f40264a

Signed-off-by: Wilson Wu <[email protected]>

Add zh content placeholders

a4e52b0

Signed-off-by: Wilson Wu <[email protected]>

Fix about zh page

1ead2cf

Signed-off-by: Wilson Wu <[email protected]>

Apply suggestions from code review

fc64d19

Co-authored-by: Huabing Zhao <[email protected]> Signed-off-by: Wilson Wu <[email protected]>

docs: %s/Application/API/g (envoyproxy#2929)

3bb526d

Signed-off-by: Wilson Wu <[email protected]>

remove old version for zh content

0773569

Signed-off-by: Wilson Wu <[email protected]>

wilsonwu force-pushed the zh-content-init branch from 5168c90 to 0773569 Compare March 19, 2024 06:13

Merge branch 'main' into zh-content-init

9f16282

Signed-off-by: Wilson Wu <[email protected]>

zhaohuabing previously approved these changes Mar 19, 2024

View reviewed changes

wilsonwu added 2 commits March 19, 2024 18:16

Update the latest version link

7b6f463

Signed-off-by: Wilson Wu <[email protected]>

Fix default content dir

080c147

Signed-off-by: Wilson Wu <[email protected]>

wilsonwu dismissed zhaohuabing’s stale review via 080c147 March 19, 2024 10:28

Xunzhuo reviewed Mar 20, 2024

View reviewed changes

site/hugo.toml Outdated Show resolved Hide resolved

Xunzhuo reviewed Mar 20, 2024

View reviewed changes

site/content/zh/_index.md Outdated Show resolved Hide resolved

wilsonwu added 2 commits March 20, 2024 11:17

Translate landing page and fix broken link

2760594

Signed-off-by: Wilson Wu <[email protected]>

Merge branch 'main' into zh-content-init

b7310ec

zirain added the hold do not merge label Mar 20, 2024

Merge branch 'main' into zh-content-init

5d63478

zhaohuabing previously approved these changes Mar 24, 2024

View reviewed changes

Fix broken link

e81fdd3

Signed-off-by: Wilson Wu <[email protected]>

wilsonwu dismissed zhaohuabing’s stale review via e81fdd3 March 24, 2024 14:24

Add a contribution page

307b949

Signed-off-by: Wilson Wu <[email protected]>

zhaohuabing approved these changes Mar 25, 2024

View reviewed changes

Merge branch 'main' into zh-content-init

e0bcc10

zirain removed the hold do not merge label Mar 25, 2024

zirain and others added 2 commits March 25, 2024 15:39

Merge branch 'main' into zh-content-init

019f87f

Merge branch 'main' into zh-content-init

abf2a56

zirain approved these changes Mar 26, 2024

View reviewed changes

zhaohuabing merged commit 275b5db into envoyproxy:main Mar 26, 2024

Conversation

wilsonwu commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilsonwu commented Jan 29, 2024

Uh oh!

codecov bot commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Xunzhuo commented Feb 23, 2024

Uh oh!

wilsonwu commented Mar 15, 2024

Uh oh!

zhaohuabing left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wilsonwu commented Mar 15, 2024

Uh oh!

zirain commented Mar 15, 2024

Uh oh!

zhaohuabing left a comment

Choose a reason for hiding this comment

Uh oh!

wilsonwu commented Mar 19, 2024

Uh oh!

zhaohuabing left a comment

Choose a reason for hiding this comment

Uh oh!

wilsonwu commented Mar 19, 2024

Uh oh!

Uh oh!

Uh oh!

zirain commented Mar 20, 2024

Uh oh!

wilsonwu commented Mar 20, 2024

Uh oh!

zhaohuabing left a comment

Choose a reason for hiding this comment

Uh oh!

wilsonwu commented Mar 24, 2024

Uh oh!

wilsonwu commented Mar 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wilsonwu commented Jan 29, 2024 •

edited

Loading

codecov bot commented Jan 29, 2024 •

edited

Loading