Skip to content

api: downstream client CACert validation#2483

Merged
zhaohuabing merged 4 commits intoenvoyproxy:mainfrom
arkodg:downstream-mtls
Jan 23, 2024
Merged

api: downstream client CACert validation#2483
zhaohuabing merged 4 commits intoenvoyproxy:mainfrom
arkodg:downstream-mtls

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Jan 22, 2024

Relates to #88

@arkodg arkodg requested a review from a team as a code owner January 22, 2024 22:45
zirain
zirain previously approved these changes Jan 23, 2024
Copy link
Copy Markdown
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zhaohuabing
zhaohuabing previously approved these changes Jan 23, 2024
@arkodg arkodg dismissed stale reviews from zhaohuabing and zirain via 7d4b2fd January 23, 2024 01:33
Arko Dasgupta added 3 commits January 22, 2024 18:03
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2b62b2) 64.66% compared to head (03c0a80) 64.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2483      +/-   ##
==========================================
+ Coverage   64.66%   64.68%   +0.02%     
==========================================
  Files         115      115              
  Lines       17465    17465              
==========================================
+ Hits        11293    11298       +5     
+ Misses       5449     5447       -2     
+ Partials      723      720       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg requested review from zhaohuabing and zirain January 23, 2024 02:20
@zhaohuabing zhaohuabing merged commit 9b6e45e into envoyproxy:main Jan 23, 2024
@arkodg arkodg deleted the downstream-mtls branch January 23, 2024 02:37
@arkodg arkodg mentioned this pull request Jan 23, 2024
arkodg pushed a commit to arkodg/gateway that referenced this pull request Feb 10, 2024
Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit that referenced this pull request Feb 14, 2024
* feat: downstream mTLS

Relates to #2483

Signed-off-by: Arko Dasgupta <[email protected]>

* configmap provider logic

Signed-off-by: Arko Dasgupta <[email protected]>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <[email protected]>

* fix charts

Signed-off-by: Arko Dasgupta <[email protected]>

* tests

Signed-off-by: Arko Dasgupta <[email protected]>

* lint

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
yaelSchechter pushed a commit to yaelSchechter/envoy-gateway that referenced this pull request Feb 14, 2024
* feat: downstream mTLS

Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <[email protected]>

* configmap provider logic

Signed-off-by: Arko Dasgupta <[email protected]>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <[email protected]>

* fix charts

Signed-off-by: Arko Dasgupta <[email protected]>

* tests

Signed-off-by: Arko Dasgupta <[email protected]>

* lint

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
zirain added a commit that referenced this pull request Feb 18, 2024
* feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default (#2585)

* Implement and update tests for the default header transformations.

Signed-off-by: Lior Okman <[email protected]>

* Make 'gen-check' happy

Signed-off-by: Lior Okman <[email protected]>

---------

Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* bug: fix merge race (#2604)

Between #2585
&
#2581

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* feat: downstream mTLS (#2490)

* feat: downstream mTLS

Relates to #2483

Signed-off-by: Arko Dasgupta <[email protected]>

* configmap provider logic

Signed-off-by: Arko Dasgupta <[email protected]>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <[email protected]>

* fix charts

Signed-off-by: Arko Dasgupta <[email protected]>

* tests

Signed-off-by: Arko Dasgupta <[email protected]>

* lint

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>

* add timeout to clientTrafficPolicy

Signed-off-by: Yael Shechter <[email protected]>

* fix comment

Signed-off-by: Yael Shechter <[email protected]>

* add omitempty

Signed-off-by: Yael Shechter <[email protected]>

* add cel test for coverage

Signed-off-by: Yael Shechter <[email protected]>

* run make commands

Signed-off-by: Yael Shechter <[email protected]>

* change request timeout field name and desc

Signed-off-by: Yael Shechter <[email protected]>

* tidy up comment

Signed-off-by: Yael Shechter <[email protected]>

* fix cel test

Signed-off-by: Yael Shechter <[email protected]>

* fix typo

Signed-off-by: Yael Shechter <[email protected]>

* run generate

Signed-off-by: Yael Shechter <[email protected]>

---------

Signed-off-by: Lior Okman <[email protected]>
Signed-off-by: Yael Shechter <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Co-authored-by: Lior Okman <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: zirain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants