sure @zirain it was a mistake.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.31%. Comparing base (4c52f10) to head (34473ed).
Report is 4 commits behind head on main.

❗ Current head 34473ed differs from pull request most recent head 870a19c. Consider uploading reports for the commit 870a19c to get more accurate results

@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   66.89%   64.31%   -2.58%     
==========================================
  Files         163      112      -51     
  Lines       23453    15728    -7725     
==========================================
- Hits        15689    10116    -5573     
+ Misses       6838     4973    -1865     
+ Partials      926      639     -287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

IMO, it is better to move this into addons or examples.

we can add a new helm chart for all these things, and it won't break the core.

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@zirain a new chart just for ServiceMonitor resource ?

new chart just for ServiceMonitor resource ?

I think that other projects also take this approach: https://github.com/istio/istio/blob/4f54ef1ba6ff4608841e76c5233827322e683a86/samples/addons/extras/prometheus-operator.yaml#L48

+1 for an addons chart that will contain additional observability examples, like the ones here: https://github.com/envoyproxy/gateway/tree/main/examples/.

I understand that why users want add this, but I do really don't want this be part of part core chart.

Option 1: be part of examples.
Option 2: part of an new addon chart(maybe it's a little early)

adding some labels to this, so we prioritize making a decision here

should this be a add-on chart (along with prom and grafana with no EG resource) or a demo/extended chart (with EG as a subchart) ?

should this be a add-on chart (along with prom and grafana with no EG resource) or a demo/extended chart (with EG as a subchart) ?

either is better than current.

Since #3470 landed, what is the status of this PR? Do we still need this?

@shawnh2 as part of #3470, did we need to define a ServiceMonitor to ensure Prometheus can scrape properly ?

@shawnh2 as part of #3470, did we need to define a ServiceMonitor to ensure Prometheus can scrape properly ?

The ServiceMonitor is used for Prometheus-operator, since we do not support this operator now, we can include this as a option in gateway-addons-helm.

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

closing this PR since its become inactive, the ServiceMonitor should be available in the gateway-addons-helm chart now
the `