Skip to content

Updates Integration Tests#196

Merged
danehans merged 1 commit intoenvoyproxy:mainfrom
danehans:resource_table_fixes
Aug 11, 2022
Merged

Updates Integration Tests#196
danehans merged 1 commit intoenvoyproxy:mainfrom
danehans:resource_table_fixes

Conversation

@danehans
Copy link
Copy Markdown
Contributor

@danehans danehans commented Aug 8, 2022

Adds ResourceTable coverage to the Kubernetes provider integration tests

Requires: #194

@danehans danehans requested a review from a team as a code owner August 8, 2022 21:39
@danehans danehans added the provider/kubernetes Issues related to the Kubernetes provider label Aug 8, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #196 (934be98) into main (f757292) will increase coverage by 2.00%.
The diff coverage is 65.67%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   59.80%   61.80%   +2.00%     
==========================================
  Files          24       25       +1     
  Lines        2065     2100      +35     
==========================================
+ Hits         1235     1298      +63     
+ Misses        758      720      -38     
- Partials       72       82      +10
Impacted Files Coverage Δ
internal/cmd/server.go 23.68% <0.00%> (ø)
internal/cmd/xdstest.go 3.65% <ø> (ø)
internal/envoygateway/config/config.go 0.00% <0.00%> (ø)
internal/gatewayapi/helpers.go 66.07% <0.00%> (-1.21%) ⬇️
internal/provider/kubernetes/kubernetes.go 58.97% <0.00%> (ø)
internal/provider/kubernetes/httproute.go 67.53% <67.92%> (+40.50%) ⬆️
internal/provider/kubernetes/gateway.go 70.90% <100.00%> (+16.04%) ⬆️
internal/provider/kubernetes/helpers.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans danehans force-pushed the resource_table_fixes branch from 934be98 to 1493668 Compare August 10, 2022 01:05
@danehans danehans mentioned this pull request Aug 10, 2022
Merged
@LukeShu
Copy link
Copy Markdown
Contributor

LukeShu commented Aug 10, 2022

On the topic of gatewayapi/helpers.go coverage going down, do we want to add -coverpkg=./... so that it doesn't matter which package the tests belong to when counting coverage?

LukeShu
LukeShu approved these changes Aug 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@LukeShu LukeShu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danehans danehans mentioned this pull request Aug 11, 2022
Closed
@danehans
Copy link
Copy Markdown
Contributor Author

danehans commented Aug 11, 2022

On the topic of gatewayapi/helpers.go coverage going down, do we want to add -coverpkg=./... so that it doesn't matter which package the tests belong to when counting coverage?

@LukeShu I created #199 to track this.

@danehans danehans merged commit 3003c65 into envoyproxy:main Aug 11, 2022
@danehans danehans deleted the resource_table_fixes branch August 26, 2022 16:57
@tmsnan tmsnan mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LukeShu LukeShu LukeShu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

provider/kubernetes Issues related to the Kubernetes provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danehans @codecov-commenter @LukeShu