[provider/kubernetes]: Watch Service objects under httpRouteReconciler#194
Conversation
chauhanshubham
changed the title
chauhanshubham
force-pushed
the
service-handling-httproute
branch
from
ecb7d2c to
c6eee2d
Compare
|
thanks for picking this issue up @chauhanshubham ! hoping this PR can be reworked on once #193 is merged so that the |
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 60.09% 59.97% -0.13%
==========================================
Files 24 25 +1
Lines 2035 2071 +36
==========================================
+ Hits 1223 1242 +19
- Misses 740 748 +8
- Partials 72 81 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chauhanshubham
force-pushed
the
service-handling-httproute
branch
from
a44e44e to
7ebecf2
Compare
Sure, having a look at that right now, will include changes once the PR gets merged. I'm guessing we'll just need HTTPRoute to be published, when associated Service CRUD happens. At the consuming side, we can get the referenced Service NamespaceName (and then obj spec) from HTTPRoute spec itself. |
yeah that approach sgtm |
minor doc changes Signed-off-by: Shubham Chauhan <[email protected]>
obj list variable should be initialized before calling client.List. Prior to this it was set to nil which caused crashes in the controller. Signed-off-by: Shubham Chauhan <[email protected]>
Add a Service watcher in httpRouteReconciler to watch for Service CRUDs. Also push affected HTTPRoutes for reconciliation on referenced Service objects CRUD. Signed-off-by: Shubham Chauhan <[email protected]>
Signed-off-by: Shubham Chauhan <[email protected]>
Signed-off-by: Shubham Chauhan <[email protected]>
Signed-off-by: Shubham Chauhan <[email protected]>
chauhanshubham
force-pushed
the
service-handling-httproute
branch
from
7ebecf2 to
30469a3
Compare
kflynn
left a comment
kflynn
left a comment
There was a problem hiding this comment.
Looks pretty sane from here...
6 participants
Adds a Service watcher in httpRouteReconciler to watch for Service CRUDs.
This also pushes affected HTTPRoutes for reconciliation when referenced
Service objects are created/updated/deleted.
Other minor updates include -
Fixing gatewayReconciler issue to initialise obj list. Object list variable should be
initialised before calling client.List(...). Prior to this it was being set to nil which
caused issues in the controller workflow.
Cleanup DefaultEnvoyGateway on server startup
Resolves #189