Skip to content

Set up watchable to communicate between components#191

Closed
LukeShu wants to merge 5 commits intoenvoyproxy:mainfrom
datawire:lukeshu/watchable
Closed

Set up watchable to communicate between components#191
LukeShu wants to merge 5 commits intoenvoyproxy:mainfrom
datawire:lukeshu/watchable

Conversation

@LukeShu
Copy link
Copy Markdown
Contributor

@LukeShu LukeShu commented Aug 3, 2022

This pulls in https://github.com/telepresenceio/watchable/ to use to communicate between components. I added a watching.md doc describing the design a bit and how to use it; I'd usually put a lot more info in the PR description, but just go read it in the markdown file. I moved the Kubernetes provider to publish its results via watchable.

As a bonus, datawire@4c1f521 is mostly moving the IR translator types over as well... but I didn't include it in this PR because something about it is causing controller-gen to crash, and I didn't want to break make generate in this PR. What's sort of weird about it is that it still writes all of the files correctly, but then crashes.

controller-gen crashing
$ make generate
make --warn-undefined-variables -f tools/make/common.mk generate
make[1]: Entering directory '/home/lukeshu/src/github.com/envoyproxy/gateway'
tools/bin/controller-gen object paths="./..."
panic: interface conversion: ast.Expr is *ast.CompositeLit, not *ast.Ident

goroutine 1463 [running]:
sigs.k8s.io/controller-tools/pkg/loader.(*referenceCollector).Visit(0xc008e31a00, {0xd5da58?, 0xc00761d9c8})
        /home/lukeshu/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/loader/refs.go:136 +0xff

@LukeShu LukeShu requested a review from a team as a code owner August 3, 2022 10:45
LukeShu added 5 commits August 3, 2022 11:24
Signed-off-by: Luke Shumaker <[email protected]>
So I notice that I forgot to set the env-var when running the server
manually.

Signed-off-by: Luke Shumaker <[email protected]>
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Aug 3, 2022

Since this PR is failing CI and @LukeShu is on leave, I created #193 to fix the CI failure. Closing this PR in favor of #193

@danehans danehans closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants