Set up watchable to communicate between components#191
Closed
LukeShu wants to merge 5 commits intoenvoyproxy:mainfrom
Closed
Set up watchable to communicate between components#191LukeShu wants to merge 5 commits intoenvoyproxy:mainfrom
LukeShu wants to merge 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Luke Shumaker <[email protected]>
…ol-plane Signed-off-by: Luke Shumaker <[email protected]>
So I notice that I forgot to set the env-var when running the server manually. Signed-off-by: Luke Shumaker <[email protected]>
Signed-off-by: Luke Shumaker <[email protected]>
Signed-off-by: Luke Shumaker <[email protected]>
e000827 to
d5bbddb
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in https://github.com/telepresenceio/watchable/ to use to communicate between components. I added a
watching.mddoc describing the design a bit and how to use it; I'd usually put a lot more info in the PR description, but just go read it in the markdown file. I moved the Kubernetes provider to publish its results via watchable.As a bonus, datawire@4c1f521 is mostly moving the IR translator types over as well... but I didn't include it in this PR because something about it is causing
controller-gento crash, and I didn't want to breakmake generatein this PR. What's sort of weird about it is that it still writes all of the files correctly, but then crashes.controller-gen crashing