-
Notifications
You must be signed in to change notification settings - Fork 711
CRDs upgrade support #4001
Copy link
Copy link
Closed
Labels
area/installationarea/upgradedocumentationImprovements or additions to documentationImprovements or additions to documentation
Milestone
Description
Description:
Currently Gateway API and EG CRDs are located in EG gateway-helm chart crds folder. This means that CRDs are not upgraded on chart upgrade, and need to be manually upgraded beforehand.
Possible solutions:
- Move crds inside templates.
Real world example: cert-manager chart has CRDs as part of templates folder and exposescrds.enabledflag.
It also allows to decide if we want to keep the CRDs on chart uninstallation withcrds.keepflag, by leveraging"helm.sh/resource-policy": keephelm annotation.
See: https://cert-manager.io/v1.13-docs/installation/helm/#crd-considerations.
However, this is a breaking change for consumers that use EG chart as a sub chart and have custom resources as part of the main chart. - Split the current chart into crds chart and application chart, and instruct to install the crds chart first.
Real world example: Istio provides a base chart that installs CRDs: https://istio.io/latest/docs/setup/install/helm/#installation-steps.
Both 1 and 2 can also solve #3094 by providing a separate flags(1)/charts(2) for Gateway API and EG CRDs.
Also Related:
- Add docs for upgrading Envoy Gateway #2031
- Create Helm chart for upstream gateway-api resources #1721
WDYT?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/installationarea/upgradedocumentationImprovements or additions to documentationImprovements or additions to documentation