Skip to content

Commit ff2c598

Browse files
alexwoalexwo
authored
fix secrets/configmap updates do not trigger a controller reconcile (#3499)
* ensure both secrets and config map reconcile upon changes ensure secret/config map changes trigger a reconcile Signed-off-by: Alex Volchok <[email protected]> * Update controller.go Signed-off-by: Alex Volchok <[email protected]> * Update controller.go Signed-off-by: Alex Volchok <[email protected]> --------- Signed-off-by: Alex Volchok <[email protected]>
1 parent 6f30397 commit ff2c598

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

‎internal/provider/kubernetes/controller.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,6 @@ func (r *gatewayAPIReconciler) watchResources(ctx context.Context, mgr manager.M
12161216

12171217
// Watch Secret CRUDs and process affected EG CRs (Gateway, SecurityPolicy, more in the future).
12181218
secretPredicates := []predicate.TypedPredicate[*corev1.Secret]{
1219-
predicate.TypedGenerationChangedPredicate[*corev1.Secret]{},
12201219
predicate.NewTypedPredicateFuncs(func(s *corev1.Secret) bool {
12211220
return r.validateSecretForReconcile(s)
12221221
}),
@@ -1237,7 +1236,6 @@ func (r *gatewayAPIReconciler) watchResources(ctx context.Context, mgr manager.M
12371236

12381237
// Watch ConfigMap CRUDs and process affected ClienTraffiPolicies and BackendTLSPolicies.
12391238
configMapPredicates := []predicate.TypedPredicate[*corev1.ConfigMap]{
1240-
predicate.TypedGenerationChangedPredicate[*corev1.ConfigMap]{},
12411239
predicate.NewTypedPredicateFuncs[*corev1.ConfigMap](func(cm *corev1.ConfigMap) bool {
12421240
return r.validateConfigMapForReconcile(cm)
12431241
}),

0 commit comments

Comments
 (0)