Skip to content

Commit f2c8b77

Browse files
zhaohuabingzhaohuabing
authored
fix: push a helm chart without v in ther version (#4636)
* push a helm chart without v in ther version Signed-off-by: Huabing Zhao <[email protected]> * rename tag Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]>
1 parent 5698e88 commit f2c8b77

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

‎.github/workflows/build_and_test.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,3 +224,4 @@ jobs:
224224
# use `0.0.0` as the default latest version.
225225
# use `Always` image pull policy for latest version.
226226
run: IMAGE_PULL_POLICY=Always OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=v0.0.0-latest TAG=latest make helm-push
227+
run: IMAGE_PULL_POLICY=Always OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=0.0.0-latest TAG=latest make helm-push

‎.github/workflows/release.yaml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ jobs:
5757
shell: bash
5858
run: |
5959
echo "release_tag=$(echo ${GITHUB_REF##*/})" >> $GITHUB_ENV
60+
echo "without_v_release_tag=${release_tag:1}" >> $GITHUB_ENV
6061
echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
6162
6263
- name: Login to DockerHub
@@ -73,6 +74,7 @@ jobs:
7374

7475
- name: Build and Push EG Release Helm Chart
7576
run: IMAGE_PULL_POLICY=IfNotPresent OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=${{ env.release_tag }} IMAGE=docker.io/envoyproxy/gateway TAG=${{ env.release_tag }} make helm-package helm-push
77+
run: IMAGE_PULL_POLICY=IfNotPresent OCI_REGISTRY=oci://docker.io/envoyproxy CHART_VERSION=${{ env.without_v_release_tag }} IMAGE=docker.io/envoyproxy/gateway TAG=${{ env.release_tag }} make helm-package helm-push
7678

7779
- name: Download Benchmark Report
7880
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8

‎release-notes/current.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ bug fixes: |
1818
The xDS translation failed when wasm http code source configured without a sha
1919
HTTPRoute status only shows one parent when targeting multiple Gateways from different GatewayClasses
2020
Route with multiple parents has incorrect namespace in parentRef status
21+
Helm chart fails for Flux HelmRelease
2122
2223
# Enhancements that improve performance.
2324
performance improvements: |

0 commit comments

Comments
 (0)