improve headless service detection logic

sudiptob2 · zirain · commit 8ef4f6beb33f · 2026-01-26T13:40:20.000+08:00
Signed-off-by: Sudipto Baral &lt;sudiptobaral.me@gmail.com&gt;
diff --git a/internal/gatewayapi/route.go b/internal/gatewayapi/route.go
@@ -1951,15 +1951,7 @@ func isServiceHeadless(service *corev1.Service) bool {
 	if service == nil {
 		return false
 	}
-	if service.Spec.ClusterIP == "None" || service.Spec.ClusterIP == "" {
-		return true
-	}
-	if len(service.Spec.ClusterIPs) > 0 {
-		for _, ip := range service.Spec.ClusterIPs {
-			if ip != "None" && ip != "" {
-				return false
-			}
-		}
+	if service.Spec.ClusterIP == corev1.ClusterIPNone {
 		return true
 	}
 	return false
diff --git a/internal/gatewayapi/route_test.go b/internal/gatewayapi/route_test.go
@@ -406,15 +406,6 @@ func TestIsServiceHeadless(t *testing.T) {
 			},
 			want: true,
 		},
-		{
-			name: "headless service with empty ClusterIP",
-			service: &corev1.Service{
-				Spec: corev1.ServiceSpec{
-					ClusterIP: "",
-				},
-			},
-			want: true,
-		},
 		{
 			name: "normal service with ClusterIP",
 			service: &corev1.Service{
@@ -428,22 +419,12 @@ func TestIsServiceHeadless(t *testing.T) {
 			name: "dual-stack headless service",
 			service: &corev1.Service{
 				Spec: corev1.ServiceSpec{
-					ClusterIP:  "10.0.0.1",
+					ClusterIP:  "None",
 					ClusterIPs: []string{"None", "None"},
 				},
 			},
 			want: true,
 		},
-		{
-			name: "dual-stack headless service (all ClusterIPs are empty)",
-			service: &corev1.Service{
-				Spec: corev1.ServiceSpec{
-					ClusterIP:  "10.0.0.1",
-					ClusterIPs: []string{"", ""},
-				},
-			},
-			want: true,
-		},
 		{
 			name: "dual-stack service with valid IPs",
 			service: &corev1.Service{
