Conversation
Signed-off-by: JP Simard <[email protected]>
Signed-off-by: JP Simard <[email protected]>
|
@Yannic I checked the error and it seems to be coming from https://github.com/google/xctestrunner/blob/master/simulator_control/simulator_util.py#L149 so I went ahead and ran on the MacOS 12 worker: Are you sure you installed Command_Line_Tools_for_Xcode_13.4.dmg ? According to https://stackoverflow.com/questions/29108172/how-do-i-fix-the-xcrun-unable-to-find-simctl-error that's how you fix that kind of error. The command succeeds in the local GH runner. |
|
Thanks @lfpino! I need to read up on the command-line tools a bit. Will provide an update next week |
|
Probably just needs this command on the executors: |
* main: tools: fix source mapping (#2429) Update Envoy (#2427) tools: add arm64 debug run configuration (#2424) Revert "docs: use sphinx githubpages extension (#2418)" (#2425) Remove Tulsi configuration & docs (#2421) Fix isCleartextTrafficPermitted (#2420) Squelch two JNI build warnings (#2426) dns: allow using the `getaddrinfo`-based system DNS resolver (#2419) docs: use sphinx githubpages extension (#2418) Update Envoy (#2417) Remove rules_cc uses Bump Lyft Support Rotation (#2414) iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415) Update Envoy (#2413) engine: remove outdated comment about `registerFactories()` (#2412) api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410) Signed-off-by: JP Simard <[email protected]>
|
The EngFlow executors have been updated to have macOS 12 & Xcode 13.4 so this is now ready for review. |
Updates the version of Xcode Envoy Mobile is compatible with to the latest stable version (sorta, 13.4.1 also exists but doesn't have relevant changes).
Risk Level: Low.
Testing: Local & CI.
Docs Changes: Done.
Release Notes: Done.
Fixes #2100
Signed-off-by: JP Simard [email protected]