api: make iOS Headers and HeadersBuilder case-insensitive#2383
Merged
Augustyniak merged 39 commits intomainfrom Jun 28, 2022
Merged
api: make iOS Headers and HeadersBuilder case-insensitive#2383Augustyniak merged 39 commits intomainfrom
Augustyniak merged 39 commits intomainfrom
Conversation
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Augustyniak
force-pushed
the
make-headers-builder-case-insensitive
branch
from
59cf05f to
c3c9015
Compare
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Augustyniak
force-pushed
the
make-headers-builder-case-insensitive
branch
from
ec84cea to
15f722b
Compare
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Augustyniak
force-pushed
the
make-headers-builder-case-insensitive
branch
from
f371032 to
516a1fc
Compare
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Augustyniak
force-pushed
the
make-headers-builder-case-insensitive
branch
from
6746393 to
42897f2
Compare
Augustyniak
changed the title
Augustyniak
changed the title
Augustyniak
changed the title
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Augustyniak
changed the title
Contributor
Author
|
@goaway This is now ready for review. I incorporate your offline feedback with regard to making |
Signed-off-by: Rafal Augustyniak <[email protected]>
Contributor
Author
Signed-off-by: Rafal Augustyniak <[email protected]>
Co-authored-by: JP Simard <[email protected]> Signed-off-by: Rafał Augustyniak <[email protected]>
Co-authored-by: JP Simard <[email protected]> Signed-off-by: Rafał Augustyniak <[email protected]>
Co-authored-by: JP Simard <[email protected]> Signed-off-by: Rafał Augustyniak <[email protected]>
Contributor
Author
Co-authored-by: JP Simard <[email protected]> Signed-off-by: Rafał Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
jpsim
previously approved these changes
Jun 28, 2022
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
goaway
reviewed
Jun 28, 2022
|
|
||
| NSMutableString *headerMessage = [NSMutableString new]; | ||
| for (NSString *name in headers.allHeaders) { | ||
| for (NSString *name in headers.caseSensitiveHeaders()) { |
goaway
previously approved these changes
Jun 28, 2022
Contributor
goaway
left a comment
goaway
left a comment
There was a problem hiding this comment.
I like this solution. Nice work @Augustyniak.
Signed-off-by: Rafal Augustyniak <[email protected]>
jpsim
approved these changes
Jun 28, 2022
jpsim
added a commit
that referenced
this pull request
Jul 5, 2022
* origin/main: Update Envoy (#2403) connectivity_manager: rename/refactor from Network::Configurator (#2401) test: fixing up build targets to use the extension registry (#2397) test: Adds an integration test for SDS (#2395) iOS: add `forceIPv6(...)` builder option (#2396) api: make iOS Headers and HeadersBuilder case-insensitive (#2383) Signed-off-by: JP Simard <[email protected]>
Augustyniak
added a commit
that referenced
this pull request
Jul 6, 2022
Description: An Android change that mimics iOS changes from #2383. Make the lookup of headers in HeadersBuilder and Headers case-insensitive and preserve the original casing of headers. Risk Level: Low Testing: Unit Docs Changes: Done Release Notes: Done Fixes: #2390 Signed-off-by: Rafal Augustyniak <[email protected]>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Description: An Android change that mimics iOS changes from envoyproxy/envoy-mobile#2383. Make the lookup of headers in HeadersBuilder and Headers case-insensitive and preserve the original casing of headers. Risk Level: Low Testing: Unit Docs Changes: Done Release Notes: Done Fixes: envoyproxy/envoy-mobile#2390 Signed-off-by: Rafal Augustyniak <[email protected]> Signed-off-by: JP Simard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Make the lookup of headers in
HeadersBuilderandHeaderscase-insensitive and preserve the original casing of headers. Implemented on iOS only. Android side-changes are going to be implemented in a follow up PR. GH issue: #2390.Risk Level: Low
Testing: Unit Tests
Docs Changes: Updated
Release Notes: Updated