Conversation
And validate that it builds successfully on CI. Ideally we'd have a whole suite of example integrations that validate all our supported installation methods, but this should be a good start. I reached out to the owner of https://catfacts.ninja to make sure this usage is within the terms of service and will update to use something else if necessary. Signed-off-by: JP Simard <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Contributor
|
Strangely, I can't even resolve the domain catfacts.ninja from my local ISP here. |
Contributor
Author
that’s the wrong domain. https://catfact.ninja |
* main: release: re-package xcframework zip (#2336) swift: generate API docs as a DocC archive (#2335) stats: include new metrics in config (#2332) Signed-off-by: JP Simard <[email protected]>
Augustyniak
previously approved these changes
Jun 3, 2022
Signed-off-by: JP Simard <[email protected]>
Augustyniak
previously approved these changes
Jun 3, 2022
* origin/main: tests: Adds an RTDS integration test for Envoy Mobile (#2328) bazel: retry repository downloads (#2338) Signed-off-by: JP Simard <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim
added a commit
that referenced
this pull request
Jun 14, 2022
* origin/main: (33 commits) iOS: fix xcframework upload in release workflow (#2366) config: hopefully fixing C++ config default for apple (#2355) Update Envoy (#2364) Bump Lyft Support Rotation (#2365) ci: pin external GitHub Action (#2363) cleanup: fix warning in JNI layer (#2361) cleanup: convert some more uses of NULL to nullptr (#2359) cleanup: consistently use nullptr in cc contexts (#2351) cleanup: remove unused function and resolve warning (#2350) iOS: add configurable gzip and brotli decompression options (#2349) iOS: stop embedding bitcode in releases (#2347) ci: update Android setup (#2354) docs: update the list of clusters (#2344) bazel: update rules_apple (#2346) iOS: add a way to disable network monitoring (#2345) api: adding brotli knobs (#2342) android: create persistent SharedPreferences-based KV store (#2319) ios: add support for registering a platform KV store (#2334) builder: making compressor configurable (#2321) iOS: add SwiftPM example (#2333) ... Signed-off-by: JP Simard <[email protected]>
jpsim
added a commit
that referenced
this pull request
Jun 14, 2022
* origin/main: (33 commits) iOS: fix xcframework upload in release workflow (#2366) config: hopefully fixing C++ config default for apple (#2355) Update Envoy (#2364) Bump Lyft Support Rotation (#2365) ci: pin external GitHub Action (#2363) cleanup: fix warning in JNI layer (#2361) cleanup: convert some more uses of NULL to nullptr (#2359) cleanup: consistently use nullptr in cc contexts (#2351) cleanup: remove unused function and resolve warning (#2350) iOS: add configurable gzip and brotli decompression options (#2349) iOS: stop embedding bitcode in releases (#2347) ci: update Android setup (#2354) docs: update the list of clusters (#2344) bazel: update rules_apple (#2346) iOS: add a way to disable network monitoring (#2345) api: adding brotli knobs (#2342) android: create persistent SharedPreferences-based KV store (#2319) ios: add support for registering a platform KV store (#2334) builder: making compressor configurable (#2321) iOS: add SwiftPM example (#2333) ... Signed-off-by: JP Simard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And validate that it builds successfully on CI.
Ideally we'd have a whole suite of example integrations that validate all our supported installation methods, but this should be a good start.
I reached out to the owner of https://catfact.ninja to make sure this usage is within the terms of service and will update to use something else if necessary.
catfacts.mp4
Signed-off-by: JP Simard [email protected]