Merged
Conversation
Signed-off-by: Alan Chiu <[email protected]>
goaway
approved these changes
Oct 14, 2021
Contributor
goaway
left a comment
goaway
left a comment
There was a problem hiding this comment.
Okay, seems fine for now. Would be nice to find a better long-term solution for logging at this layer though.
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Oct 21, 2021
* origin/main: [Apple] Guess string encoding when creating an NSString with UTF8 fails (envoyproxy#1891) Link android dev document in a doctree (envoyproxy#1892) bazel: Remove rules_jvm_external dep on JAVA_HOME (envoyproxy#1890) release: 0.4.3.20211020 (envoyproxy#1887) Add debug instructions and sample bazelproject (envoyproxy#1888) bazel: Use hermetic JDK 11 (envoyproxy#1863) envoy: bump upstream to c687308 (envoyproxy#1886) docs: how to test with local envoy (envoyproxy#1876) network: implement initial heuristic for binding alternate interface (envoyproxy#1858) Assign an int to each log level (envoyproxy#1885) envoy: bump upstream to a5b3af2 (envoyproxy#1884) android: stub out jni logging by default (envoyproxy#1879) CI: Add local JDK to asan/tsan builds (envoyproxy#1878) Make JniBridgeUtility public (envoyproxy#1880) swift: Fix Swift version in podspec (envoyproxy#1875) Signed-off-by: JP Simard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These logs are quite spammy in practice without any meaningful information. The proposal here is to avoid spamming Android logs and rely on this for unit test debugging or local development debugging.
Signed-off-by: Alan Chiu [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: android: stub out jni logging by default
Risk Level: low
Testing: local
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]