docs: how to test with local envoy#1876
Merged
buildbreaker merged 3 commits intoenvoyproxy:mainfrom Oct 18, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <[email protected]>
jpsim
previously approved these changes
Oct 14, 2021
Contributor
jpsim
left a comment
jpsim
left a comment
There was a problem hiding this comment.
Nice, thanks for writing this up.
| not be reflected when you create a draft pull request so can not be used to verify | ||
| that the Envoy Mobile build bots will pass. | ||
|
|
||
| To test Envoy changes against CI, make those changes in your Envoy repo, push that branch to github |
Contributor
There was a problem hiding this comment.
Nit: s/github/GitHub/
Suggested change
| To test Envoy changes against CI, make those changes in your Envoy repo, push that branch to github | |
| To test Envoy changes against CI, make those changes in your Envoy repo, push that branch to GitHub |
| that the Envoy Mobile build bots will pass. | ||
|
|
||
| To test Envoy changes against CI, make those changes in your Envoy repo, push that branch to github | ||
| and change the ``.gitmodules`` file in the Envoy Mobile repo to point to your Envoy branch like so:: |
Contributor
There was a problem hiding this comment.
Extra colon
Suggested change
| and change the ``.gitmodules`` file in the Envoy Mobile repo to point to your Envoy branch like so:: | |
| and change the ``.gitmodules`` file in the Envoy Mobile repo to point to your Envoy branch like so: |
Contributor
Author
There was a problem hiding this comment.
thats's actually mark up (new one to me too) that makes it the greyed out section
Contributor
There was a problem hiding this comment.
Ah, my mistake, thanks for letting me know!
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Oct 21, 2021
* origin/main: [Apple] Guess string encoding when creating an NSString with UTF8 fails (envoyproxy#1891) Link android dev document in a doctree (envoyproxy#1892) bazel: Remove rules_jvm_external dep on JAVA_HOME (envoyproxy#1890) release: 0.4.3.20211020 (envoyproxy#1887) Add debug instructions and sample bazelproject (envoyproxy#1888) bazel: Use hermetic JDK 11 (envoyproxy#1863) envoy: bump upstream to c687308 (envoyproxy#1886) docs: how to test with local envoy (envoyproxy#1876) network: implement initial heuristic for binding alternate interface (envoyproxy#1858) Assign an int to each log level (envoyproxy#1885) envoy: bump upstream to a5b3af2 (envoyproxy#1884) android: stub out jni logging by default (envoyproxy#1879) CI: Add local JDK to asan/tsan builds (envoyproxy#1878) Make JniBridgeUtility public (envoyproxy#1880) swift: Fix Swift version in podspec (envoyproxy#1875) Signed-off-by: JP Simard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we have this docced up somewhere and it has come up a few times