Skip to content

CI: Move tsan workflow to Engflow's remote execution#1781

Merged
goaway merged 20 commits intoenvoyproxy:mainfrom
lfpino:luis-tsan
Sep 10, 2021
Merged

CI: Move tsan workflow to Engflow's remote execution#1781
goaway merged 20 commits intoenvoyproxy:mainfrom
lfpino:luis-tsan

Conversation

@lfpino
Copy link
Copy Markdown
Contributor

@lfpino lfpino commented Sep 2, 2021

Description:
CI: Move tsan workflow to Engflow's remote execution

Same as #1745 but using a couple of tsan flags instead of asan. Using a separate config for modularity.

Risk Level: Low
Testing: See tsan workflow
Docs Changes: N/A
Release Notes: N/A

lfpino added 14 commits August 24, 2021 17:26
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
Signed-off-by: Luis Fernando Pino Duque <[email protected]>
@lfpino lfpino marked this pull request as ready for review September 2, 2021 21:46
@lfpino
Copy link
Copy Markdown
Contributor Author

lfpino commented Sep 2, 2021

@goaway This is identical to ASAN but with a few different flags. Please take a look

I also cleaned up some redundant flags and once we finish more flows we can see how to unify better the configs.

Copy link
Copy Markdown
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lfpino! LGTM, pending CI.

Copy link
Copy Markdown
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And since tsan already passed, looks like this will be good to go when it completes.

@lfpino
Copy link
Copy Markdown
Contributor Author

lfpino commented Sep 6, 2021

I think you can merge now.

lfpino and others added 4 commits September 7, 2021 14:31
@lfpino lfpino requested a review from goaway September 10, 2021 13:49
@goaway goaway merged commit 06f00ad into envoyproxy:main Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants