tracing: google grpc service support for ocagent/opencensus#9955
Merged
mattklein123 merged 16 commits intoenvoyproxy:masterfrom Feb 17, 2020
Merged
tracing: google grpc service support for ocagent/opencensus#9955mattklein123 merged 16 commits intoenvoyproxy:masterfrom
mattklein123 merged 16 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: michael.wozniak <[email protected]>
wozz
force-pushed
the
opencensus_grpc_service
branch
from
5ab34ef to
8d2c041
Compare
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
dio
reviewed
Feb 9, 2020
Member
dio
left a comment
dio
left a comment
There was a problem hiding this comment.
Flushing a high-level comment. Seems like you need to add a test as well?
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
Member
|
Looks good. Should we have a test for this? |
Signed-off-by: michael.wozniak <[email protected]>
Contributor
Author
|
I added a test for the new config option, however I'm not sure if you mean to set up a mock service and actually connect to it. I don't see tests currently that do that for the existing exporters, so I'm not sure how I would do that. |
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
Signed-off-by: michael.wozniak <[email protected]>
Contributor
Author
|
the test failure doesn't seem to be related to these changes as far as I can tell |
Signed-off-by: michael.wozniak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: support a grpc service for opencensus tracing ocagent backend. this allows more fine grained control over the grpc connection to the ocagent and exposes more settings for the connection.
Risk Level: low
Testing: there don't appear to be tests around this part of the code at the moment. would be open to suggestions about how to add tests for this.
Docs Changes: updated docs for new proto field
Release Notes: added note to existing release note