string matcher: add ignore_case to StringMatcher#9868
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Jan 30, 2020
Merged
string matcher: add ignore_case to StringMatcher#9868mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yangmin Zhu <[email protected]>
Contributor
Author
lizan
reviewed
Jan 29, 2020
kyessenov
reviewed
Jan 29, 2020
mattklein123
requested changes
Jan 29, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with small comments.
/wait
Signed-off-by: Yangmin Zhu <[email protected]>
lizan
reviewed
Jan 29, 2020
Signed-off-by: Yangmin Zhu <[email protected]>
mattklein123
requested changes
Jan 29, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with one test request.
/wait
Signed-off-by: Yangmin Zhu <[email protected]>
Contributor
Author
|
This needs to be back-ported to 1.2 and 1.3 but it seems I cannot add the @lizan @PiotrSikora Could you approve the backport request? Thank you. |
Contributor
|
/backport |
repokitteh-read-only
bot
added
the
backport/review
Contributor
|
(that's how you add it) |
PiotrSikora
added
backport/approved
yangminzhu
added a commit
to yangminzhu/envoy
that referenced
this pull request
Feb 12, 2020
Signed-off-by: Yangmin Zhu <[email protected]>
yangminzhu
added a commit
to yangminzhu/envoy
that referenced
this pull request
Feb 12, 2020
Signed-off-by: Yangmin Zhu <[email protected]>
PiotrSikora
pushed a commit
that referenced
this pull request
Feb 12, 2020
Signed-off-by: Yangmin Zhu <[email protected]>
PiotrSikora
pushed a commit
that referenced
this pull request
Feb 12, 2020
Signed-off-by: Yangmin Zhu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yangmin Zhu [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: add ignore_case to StringMatcher that allows case insensitive exact/prefix/suffix string matching
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]