Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have increasing use cases where we want Envoy filters to be able to make
direct HTTP calls but use the full router feature set (retries, etc.). We also want
all of the same stats. Previously, the HTTP async client didn't support most of
the router features and also had some code duplication. This change makes the
HTTP async client use the router directly so that all standard features are
available via request headers directly.
In follow ups we will add the ability for the async client to write to an access log,
as well as for a constant route to be passed in, which will be higher
performance than having to use request headers that need to be parsed.