Skip to content

api: deprecate tls_context in favor of transport socket#8508

Merged
htuch merged 19 commits intoenvoyproxy:masterfrom
lizan:tls_context_deprecate
Oct 25, 2019
Merged

api: deprecate tls_context in favor of transport socket#8508
htuch merged 19 commits intoenvoyproxy:masterfrom
lizan:tls_context_deprecate

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Oct 6, 2019

Signed-off-by: Lizan Zhou [email protected]

Description:
Deprecates tls_context in favor of transport socket.

Risk Level: Low
Testing: CI
Docs Changes: Added
Release Notes: Added
Fixes #8098.

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Oct 6, 2019

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8508 was opened by lizan.

see: more, trace.

lizan added 4 commits October 6, 2019 03:24
@lizan
format
fbd00da 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
format again
9f9eebb 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
modernize tests
7fa1d97 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
format
5aa7a96 
Signed-off-by: Lizan Zhou <[email protected]>
htuch
htuch reviewed Oct 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking this on for v3, just a couple of questions..

@lizan lizan mentioned this pull request Oct 9, 2019
Open
4 tasks
htuch
htuch previously approved these changes Oct 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome, thanks for getting this into v3.

@htuch
Copy link
Copy Markdown
Member

htuch commented Oct 11, 2019

@lizan needs master merge, good to go otherwise.

lizan
lizan commented Oct 12, 2019
View reviewed changes
api/envoy/api/v3alpha/BUILD Outdated
has_services = True,
deps = [
"//envoy/api/v3alpha/auth:pkg",
"//envoy/api/v2/auth:pkg",
Copy link
Copy Markdown
Member Author

@lizan lizan Oct 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htuch I merged master and then try to use fix_format to address merge conflicts in v3alpha, then this sneaked in and passes format check. seems like a bug.

Copy link
Copy Markdown
Member

@htuch htuch Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this seems a bit off. I'll take a look.

@stale
Copy link
Copy Markdown

stale bot commented Oct 20, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 20, 2019
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Oct 20, 2019
@htuch
Copy link
Copy Markdown
Member

htuch commented Oct 22, 2019

@lizan can you merge master and get CI passing? This is ready to go. Thanks.
/wait

@lizan
Copy link
Copy Markdown
Member Author

lizan commented Oct 24, 2019

@htuch this is good to go.

@htuch
Copy link
Copy Markdown
Member

htuch commented Oct 25, 2019

@lizan more master merge needed :)

@lizan
Copy link
Copy Markdown
Member Author

lizan commented Oct 25, 2019

@htuch merged

htuch
htuch approved these changes Oct 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit b4ca603 into envoyproxy:master Oct 25, 2019
@lizan lizan deleted the tls_context_deprecate branch October 28, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssawilk alyssawilk Awaiting requested review from alyssawilk

@mattklein123 mattklein123 Awaiting requested review from mattklein123

1 more reviewer

@htuch htuch htuch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@htuch htuch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v3 API: move tls_context to transport_socket only

2 participants

@lizan @htuch