router check tool: add flag for only printing failed tests#8160
Merged
mattklein123 merged 22 commits intoenvoyproxy:masterfrom Sep 11, 2019
Merged
router check tool: add flag for only printing failed tests#8160mattklein123 merged 22 commits intoenvoyproxy:masterfrom
mattklein123 merged 22 commits intoenvoyproxy:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For teams that have large numbers of tests, printing all test names can be cumbersome and make it hard to debug. For this reason, this change adds a new command line flag for the router check tool which when set only shows test results for tests that have failed.
When this flag is set alongside the detailed flag, only results for failed tests are printed.
When only the detailed flag is set, all test names are shown and names for failed tests are not printed again.
When only the new flag is set, only test results for failed tests are printed.
When neither flag is set, there is no output.
Risk Level: Low
Testing:
Added unit tests for expected output under different details & only_show_failures flag combinations in route_tests.sh.
Docs Changes: included
Release Notes: included
[Optional Fixes #Issue]
[Optional Deprecated:]