udp_listener: refactor ActiveUdpListener creation#7884
Merged
mattklein123 merged 28 commits intoenvoyproxy:masterfrom Aug 26, 2019
Merged
udp_listener: refactor ActiveUdpListener creation#7884mattklein123 merged 28 commits intoenvoyproxy:masterfrom
mattklein123 merged 28 commits intoenvoyproxy:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify ListenerConfig to provide a listener factory if the socket is a UDP socket through a new interface udpListenerFactory().
Modify ConnectionHandlerImpl to addListener() through the new interface.
Add a new member of type envoy::api::v2::listener::UdpListenerConfig in envoy::api::v2::Listener to take a user specified config for the UDP listener.
Risk Level: medium, bad config can create a UDP listener which is not production-ready.
Testing: re-use existing connection_handler_test, listener_manager_test and udp integration tests.
Part of #7433, #2557