Skip to content

[xds] refactor config provider framework#7704

Merged
htuch merged 29 commits intoenvoyproxy:masterfrom
stevenzzzz:config-provider-update
Aug 1, 2019
Merged

[xds] refactor config provider framework#7704
htuch merged 29 commits intoenvoyproxy:masterfrom
stevenzzzz:config-provider-update

Conversation

@stevenzzzz
Copy link
Copy Markdown
Contributor

Signed-off-by: Xin Zhuang [email protected]

Description: Refactor config provider to:

  • Move creation of Config implementation from x-ConfigProviders to x-Subscriptions, so that we can
    share one Config implementation across workers in a DeltaConfigSubscriptionInstance and its associated providers, and share one Config impl across all works and all providers in a ConfigSubscriptionInstance and its associated providers.
  • Remove DeltaMutableConfigProviderBase, and MutableConfigProviderBase as now their functionality is covered by the DeltaConfigSubscriptionInstance/ConfigSubscriptionInstance impl.
  • Adjusted tests.

Risk Level: LOW (no production code)
Testing: unit tests
Docs Changes: N/A
Release Notes: N/A

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants