example: add csrf sandbox#6805
Conversation
Signed-off-by: Derek Schaller <[email protected]>
Signed-off-by: Derek Schaller <[email protected]>
Signed-off-by: Derek Schaller <[email protected]>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, thank you! Yay for more examples!
@moderation any interest in giving this a quick glance?
moderation
left a comment
moderation
left a comment
There was a problem hiding this comment.
I couldn't get the sandbox to work as documented. I think some changes are required to the documentation and possibly re: localhost vs 127.0.0.1.
Signed-off-by: Derek Schaller <[email protected]>
Signed-off-by: Derek Schaller <[email protected]>
|
@moderation I overhauled things a bit. Let me know what you think. |
Signed-off-by: Derek Schaller <[email protected]>
Signed-off-by: Derek Schaller <[email protected]>
moderation
left a comment
moderation
left a comment
There was a problem hiding this comment.
Considering we removed the requirement for Docker Machine in the sandboxes I'd rather not add it back for the CSRF sandbox. Using vanilla Docker and Docker Compose with different ports will have the same effect with a lot less software and virtualization.
Signed-off-by: Derek Schaller <[email protected]>
|
@moderation updated to remove docker-machine references and bind the services to different ports |
|
@moderation mind taking another pass? |
|
LGTM. I went through and followed the steps and confirmed that the containers come up, the tests work as expected and the stats output looks good. Thanks. |
|
Thank you @moderation and @dschaller! |
* master: (65 commits) proto: Add PATCH method to RequestMethod enum (envoyproxy#6737) exe: drop unused deps on zlib compressor code (envoyproxy#7022) coverage: fix some misc coverage (envoyproxy#7033) Enable proto schema for router_check_tool (envoyproxy#6992) stats: rework stat sink flushing to centralize counter latching (envoyproxy#6996) [test] convert lds api test config stubs to v2 (envoyproxy#7021) router: scoped rds (2c): implement scoped rds API (envoyproxy#6932) build: Add option for size-optimized binary (envoyproxy#6960) test: adding an integration test framework for file-based LDS (envoyproxy#6933) doc: update obsolete ref to api/XDS_PROTOCOL.md (envoyproxy#7002) dispatcher: faster runOnAllThreads (envoyproxy#7011) example: add csrf sandbox (envoyproxy#6805) fix syntax of gcov exclusion zone. (envoyproxy#7023) /runtime_modify: add support for query params in body (envoyproxy#6977) stats: Create stats for http codes with the symbol table. (envoyproxy#6733) health check: fix more fallout from inline deletion change (envoyproxy#6988) Max heap fix (envoyproxy#7016) Add support to unregister from lifecycle notifications (envoyproxy#6984) build spdy_core_alt_svc_wire_format (envoyproxy#7010) ext_authz: Make sure initiateCall only called once (envoyproxy#6949) ... Signed-off-by: Michael Puncel <[email protected]>
3 participants
Signed-off-by: Derek Schaller [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: add a CSRF sandbox to the examples.
Risk Level: Low
Testing: Manually built and tested sandbox
Docs Changes: Included
Release Notes: Included