docs/configs/examples: use envoy-dev images#6357
Conversation
We need to think about whether we want to have all of these somehow reference some type of environment variable that would point to the right image in the context of the tree the user is looking at, but given that the trunk documentation may require a master build, this is more correct. Signed-off-by: Matt Klein <[email protected]>
|
cc @bndw @moderation |
|
LGTM. Hopefully this will help with people trying out the sandboxes and will align test images to master doco. |
|
I think this will immediately help folks, but I wonder if the real source of the friction here is defaulting users to docs/configs/examples at the current HEAD of development, instead of an official release. Theoretical exampleSarah grabs the latest official release of Envoy from Dockerhub, then heads to the docs for a configuration example. She grabs a simple example and immediately finds it's incompatible! Frustration ensues. If the majority of docs/configs/examples consumers are Envoy users and not developers, it may make sense to reorganize things to prefer |
|
To @bndw's point, we really want Might need some templating that depends on the build type when the docs are generated. |
|
I agree which is why I refer to an env variable above (templating is more accurate). Thoughts on still merging this as I think it's getting us back to where we were previously? |
htuch
left a comment
There was a problem hiding this comment.
Sure, fine to merge, maybe file issue.
We need to think about whether we want to have all of these somehow
reference some type of environment variable that would point to the
right image in the context of the tree the user is looking at, but
given that the trunk documentation may require a master build, this
is more correct.