added example for delay fault injection#5816
Conversation
Signed-off-by: Kim Saabye Pedersen <[email protected]>
kimsaabyepedersen
force-pushed
the
master
branch
from
c39cf7b to
5edf3e4
Compare
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Left a comment on the language, but otherwise LGTM.
Thanks for adding another example!
examples/fault-injection/README.md
Outdated
| bash enable_delay_fault_injection.sh | ||
| ``` | ||
|
|
||
| The script above enables HTTP 3.000 ms delays for 50% of the requests. So, you should now see a continuous sequence of HTTP 200 |
There was a problem hiding this comment.
Maybe something like The script above will add a 3 second delay to 50% of HTTP requests? I know you matched the phrasing for aborts, but I think it might flow better
Aslo, English uses commas for thousands separators, so you'd want to use 3,000 (instead of 3.000) if you're talking in terms of milliseconds.
There was a problem hiding this comment.
Thanks for the feedback. I have changed the wording.
|
You'll need to fix up DCO on the last commit, see https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#fixing-dco |
Signed-off-by: Kim Saabye Pedersen <[email protected]>
kimsaabyepedersen
force-pushed
the
master
branch
from
8a59711 to
8f8f023
Compare
|
DCO has been fixed, thanks for the feedback. |
Signed-off-by: Kim Saabye Pedersen <[email protected]> Signed-off-by: Fred Douglas <[email protected]>
3 participants
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Added a new example of fault injection: delay fault injection
Risk Level: Low
Testing: Manually tested
Docs Changes: changed the readme in the example
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]