"verify_subject_alt_name" should accept an array of strings#569
Conversation
This commit cleans up a few leftovers from envoyproxy#559 .
|
LGTM, but I can't approve it. |
|
@mattklein123 PTAL BTW is there any existing test cases for config_schemas.cc? If yes can you please point me to the test file? |
|
@ccaraman can you take a look at this? I'm a little confused how this passed tests even without the schema change? |
|
@lookuptable please sign CLA also |
|
@mattklein123 Signed! |
|
@mattklein123 It passed because the A more complete fix would be to pull the SSLContext into its own schema and move the check into https://github.com/lyft/envoy/blob/9dcac8ca111ecc8da059d1f8d42eb766b44bacd6/source/common/ssl/context_config_impl.cc#L17 I can do this later this week. @lookuptable No, we don't have tests for explicit tests for our schemas other than some places where we load a config that we expect to fail. I've added #572 |
|
Yes, but for the change to configgen.py, how did that pass tests previously. That is related to upstream. That should generate a config that does not load. Do we not test that case in the example config tests? |
|
@lookuptable it's not perfect, but you should be able to add a test for a listener that sets verify_subject_alt_name like here: https://github.com/lyft/envoy/blob/master/test/server/configuration_impl_test.cc#L124 I'm guessing in the configgen.py case, we just don't generate an example config with dynamo in it, since I know I fixed this case in our internal configs. |
Signed-off-by: John Plevyak <[email protected]>
Previously, the artifacts would appear on GitHub Actions as: - `envoy_android_aar.zip` - `envoy_ios_framework.zip` These would then unzip to: - `envoy_android_aar.zip.zip` - `envoy_android_aar.zip/envoy.aar` And: - `envoy_ios_framework.zip.zip` - `envoy_ios_framework.zip/Envoy` - `envoy_ios_framework.zip/Headers` - `envoy_ios_framework.zip/Modules` This was confusing and actually ended up mis-naming both the zip files and the framework. With the changes in this PR, the new artifacts will be: - `envoy_android_aar` - `envoy_ios_framework` And will unzip to: - `envoy_android_aar.zip` - `envoy_android_aar/envoy.aar` And: - `envoy_ios_framework.zip` - `envoy_ios_framework/Envoy.framework/*` Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
Previously, the artifacts would appear on GitHub Actions as: - `envoy_android_aar.zip` - `envoy_ios_framework.zip` These would then unzip to: - `envoy_android_aar.zip.zip` - `envoy_android_aar.zip/envoy.aar` And: - `envoy_ios_framework.zip.zip` - `envoy_ios_framework.zip/Envoy` - `envoy_ios_framework.zip/Headers` - `envoy_ios_framework.zip/Modules` This was confusing and actually ended up mis-naming both the zip files and the framework. With the changes in this PR, the new artifacts will be: - `envoy_android_aar` - `envoy_ios_framework` And will unzip to: - `envoy_android_aar.zip` - `envoy_android_aar/envoy.aar` And: - `envoy_ios_framework.zip` - `envoy_ios_framework/Envoy.framework/*` Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
4 participants
This commit cleans up a few leftovers from #559 .