http2: add header map stats histograms#45479
Merged
Merged
Conversation
Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov
enabled auto-merge (squash)
June 5, 2026 18:42
Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov
disabled auto-merge
June 5, 2026 19:42
yanavlasov
enabled auto-merge (squash)
June 5, 2026 19:42
nezdolik
reviewed
Jun 9, 2026
| if (stream) { | ||
| const int32_t stream_id = stream->stream_id_; | ||
|
|
||
| recordHistogramsForStream(*stream); |
Member
There was a problem hiding this comment.
do we want to record zero values for those histograms when stream is closed and headers have not been received yet (could skew the data)? we could add a check here if any headers have been received.
Contributor
Author
There was a problem hiding this comment.
It is probably ok, since the more interesting data is the maximum values.
wbpcode
previously approved these changes
Jun 9, 2026
wbpcode
left a comment
wbpcode
left a comment
Member
There was a problem hiding this comment.
histogram is not cheap. do we actually need this or actually access log could provide the same observability?
wbpcode
reviewed
Jun 9, 2026
wbpcode
left a comment
wbpcode
left a comment
Member
There was a problem hiding this comment.
histogram is not cheap. do we actually need this or actually access log could provide the same observability?
Contributor
Author
I do not think we have this data for the access log. The histogram is disabled by default and is an aid for users who need to tune cookie sizes. This will be removed once we have determined good limits on the H/2 cookie headers. |
nezdolik
approved these changes
Jun 9, 2026
phlax
pushed a commit
that referenced
this pull request
Jun 10, 2026
Add histograms for HTTP/2 header map stats. * header_count - total count of header entries received (including individual ``cookie`` headers) * header_list_size - total byte size of header map entries, total length of the re-assembled ``cookie`` * cookie_count - count of individual ``cookie`` headers. * cookie_size - size of re-assembled ``cookie`` headers. Histograms are disabled by default and can be enabled by setting the runtime guard ``envoy.reloadable_features.http2_record_histograms`` to ``true``. Risk Level: low Testing: unit tests Docs Changes: yes Release Notes: yes Platform Specific Features: no Runtime guard: envoy.reloadable_features.http2_record_histograms --------- Signed-off-by: Yan Avlasov <[email protected]>
nezdolik
pushed a commit
that referenced
this pull request
Jun 10, 2026
Add histograms for HTTP/2 header map stats. * header_count - total count of header entries received (including individual ``cookie`` headers) * header_list_size - total byte size of header map entries, total length of the re-assembled ``cookie`` * cookie_count - count of individual ``cookie`` headers. * cookie_size - size of re-assembled ``cookie`` headers. Histograms are disabled by default and can be enabled by setting the runtime guard ``envoy.reloadable_features.http2_record_histograms`` to ``true``. Risk Level: low Testing: unit tests Docs Changes: yes Release Notes: yes Platform Specific Features: no Runtime guard: envoy.reloadable_features.http2_record_histograms --------- Signed-off-by: Yan Avlasov <[email protected]>
nezdolik
pushed a commit
that referenced
this pull request
Jun 10, 2026
Add histograms for HTTP/2 header map stats. * header_count - total count of header entries received (including individual ``cookie`` headers) * header_list_size - total byte size of header map entries, total length of the re-assembled ``cookie`` * cookie_count - count of individual ``cookie`` headers. * cookie_size - size of re-assembled ``cookie`` headers. Histograms are disabled by default and can be enabled by setting the runtime guard ``envoy.reloadable_features.http2_record_histograms`` to ``true``. Risk Level: low Testing: unit tests Docs Changes: yes Release Notes: yes Platform Specific Features: no Runtime guard: envoy.reloadable_features.http2_record_histograms --------- Signed-off-by: Yan Avlasov <[email protected]>
phlax
pushed a commit
that referenced
this pull request
Jun 10, 2026
Add histograms for HTTP/2 header map stats. * header_count - total count of header entries received (including individual ``cookie`` headers) * header_list_size - total byte size of header map entries, total length of the re-assembled ``cookie`` * cookie_count - count of individual ``cookie`` headers. * cookie_size - size of re-assembled ``cookie`` headers. Histograms are disabled by default and can be enabled by setting the runtime guard ``envoy.reloadable_features.http2_record_histograms`` to ``true``. Risk Level: low Testing: unit tests Docs Changes: yes Release Notes: yes Platform Specific Features: no Runtime guard: envoy.reloadable_features.http2_record_histograms --------- Signed-off-by: Yan Avlasov <[email protected]>
nezdolik
pushed a commit
to nezdolik/envoy
that referenced
this pull request
Jun 16, 2026
Add histograms for HTTP/2 header map stats. * header_count - total count of header entries received (including individual ``cookie`` headers) * header_list_size - total byte size of header map entries, total length of the re-assembled ``cookie`` * cookie_count - count of individual ``cookie`` headers. * cookie_size - size of re-assembled ``cookie`` headers. Histograms are disabled by default and can be enabled by setting the runtime guard ``envoy.reloadable_features.http2_record_histograms`` to ``true``. Risk Level: low Testing: unit tests Docs Changes: yes Release Notes: yes Platform Specific Features: no Runtime guard: envoy.reloadable_features.http2_record_histograms --------- Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Jul 6, 2026
Add histograms for HTTP/2 header map stats. * header_count - total count of header entries received (including individual ``cookie`` headers) * header_list_size - total byte size of header map entries, total length of the re-assembled ``cookie`` * cookie_count - count of individual ``cookie`` headers. * cookie_size - size of re-assembled ``cookie`` headers. Histograms are disabled by default and can be enabled by setting the runtime guard ``envoy.reloadable_features.http2_record_histograms`` to ``true``. Risk Level: low Testing: unit tests Docs Changes: yes Release Notes: yes Platform Specific Features: no Runtime guard: envoy.reloadable_features.http2_record_histograms --------- Signed-off-by: Yan Avlasov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add histograms for HTTP/2 header map stats.
cookieheaders)cookiecookieheaders.cookieheaders.Histograms are disabled by default and can be enabled by
setting the runtime guard
envoy.reloadable_features.http2_record_histogramstotrue.Risk Level: low
Testing: unit tests
Docs Changes: yes
Release Notes: yes
Platform Specific Features: no
Runtime guard: envoy.reloadable_features.http2_record_histograms