dynamic_modules: refactor RUST SDK to add repr(transparent)#43798
Merged
agrawroh merged 1 commit intoenvoyproxy:mainfrom Mar 5, 2026
Merged
dynamic_modules: refactor RUST SDK to add repr(transparent)#43798agrawroh merged 1 commit intoenvoyproxy:mainfrom
agrawroh merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
Member
Author
My understanding, looking at the docs is this: |
mathetake
approved these changes
Mar 5, 2026
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…xy#43798) ## Description We are missing `#[repr(transparent)]` on the metrics methods. This PR is to add it. --- **Commit Message:** dynamic_modules: refactor RUST SDK to add repr(transparent) **Additional Description:** Added missing `#[repr(transparent)]` on the metrics methods. **Risk Level:** Low **Testing:** CI **Docs Changes:** N/A **Release Notes:** N/A Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: bjmask <[email protected]>
bvandewalle
pushed a commit
to bvandewalle/envoy
that referenced
this pull request
Mar 17, 2026
…xy#43798) ## Description We are missing `#[repr(transparent)]` on the metrics methods. This PR is to add it. --- **Commit Message:** dynamic_modules: refactor RUST SDK to add repr(transparent) **Additional Description:** Added missing `#[repr(transparent)]` on the metrics methods. **Risk Level:** Low **Testing:** CI **Docs Changes:** N/A **Release Notes:** N/A Signed-off-by: Rohit Agrawal <[email protected]>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…xy#43798) ## Description We are missing `#[repr(transparent)]` on the metrics methods. This PR is to add it. --- **Commit Message:** dynamic_modules: refactor RUST SDK to add repr(transparent) **Additional Description:** Added missing `#[repr(transparent)]` on the metrics methods. **Risk Level:** Low **Testing:** CI **Docs Changes:** N/A **Release Notes:** N/A Signed-off-by: Rohit Agrawal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are missing
#[repr(transparent)]on the metrics methods. This PR is to add it.Commit Message: dynamic_modules: refactor RUST SDK to add repr(transparent)
Additional Description: Added missing
#[repr(transparent)]on the metrics methods.Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A