Skip to content

Update xDS API version in repository_locations.bzl#41335

Merged
phlax merged 5 commits into
envoyproxy:mainfrom
mmorel-35:xds
Oct 23, 2025
Merged

Update xDS API version in repository_locations.bzl#41335
phlax merged 5 commits into
envoyproxy:mainfrom
mmorel-35:xds

Conversation

@mmorel-35

Copy link
Copy Markdown
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41335 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Oct 2, 2025
@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #41335 was opened by mmorel-35.

see: more, trace.

@phlax

phlax commented Oct 2, 2025

Copy link
Copy Markdown
Member

you will need to update the sha and release date also

there is a tool you can use - eg

bazel run //bazel:api-update com_github_cncf_xds $VERSION_OR_SHA

@mmorel-35

Copy link
Copy Markdown
Contributor Author

For now I just want to validate cncf/xds#123

@phlax

phlax commented Oct 2, 2025

Copy link
Copy Markdown
Member

bazel wont load the dep if the sha is incorrect

@mmorel-35
mmorel-35 marked this pull request as ready for review October 14, 2025 14:38
@mmorel-35

Copy link
Copy Markdown
Contributor Author

@phlax ,

I provided the commit in the main branch of xds after it has been merged

@phlax

phlax commented Oct 14, 2025

Copy link
Copy Markdown
Member

cool thanks @mmorel-35 - we are about to publish a release - will land this once its out of the way

@phlax phlax self-assigned this Oct 14, 2025
@RyanTheOptimist

Copy link
Copy Markdown
Contributor

@phlax Is this ready to land now?

@phlax phlax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 23, 2025
@phlax
phlax merged commit 50b960a into envoyproxy:main Oct 23, 2025
25 checks passed
@mmorel-35
mmorel-35 deleted the xds branch October 23, 2025 18:45
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants