Improve matcher tests#39603
Merged
Merged
Conversation
Signed-off-by: Raven Black <[email protected]>
Contributor
|
/wait for #38726 |
Signed-off-by: Raven Black <[email protected]>
Signed-off-by: Raven Black <[email protected]>
kyessenov
approved these changes
May 29, 2025
phlax
pushed a commit
that referenced
this pull request
May 29, 2025
Commit Message: Fix forward on a bad merge Additional Description: Broke a test by adding it and changing the test format at the same time. (#38986 + #39603) Risk Level: None Testing: Test-only Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Improve matcher tests
Additional Description: This is how gtests are supposed to work.
NOTE: please do not merge until #38726 is in, to avoid provoking a merge conflict on a PR that's already been embattled.
Before:
After:
(Note, both failures actually are on line 44 of prefix_map_matcher_test, but only the "after" version says so.)
Risk Level: None, test-only.
Testing: Yes it is.
Docs Changes: n/a
Release Notes: n/a (unless we need a release note in case someone was using these test helpers in an external extension?)
Platform Specific Features: n/a