clean up: remove senseless interfaces#39460
Merged
RyanTheOptimist merged 6 commits intoenvoyproxy:mainfrom May 14, 2025
Merged
Conversation
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Member
Author
|
/retest |
Member
Author
|
/assign @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers cannot be assigned to this issue. |
Member
Author
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @RyanTheOptimist |
RyanTheOptimist
approved these changes
May 14, 2025
fishpan1209
pushed a commit
to fishpan1209/envoy
that referenced
this pull request
May 22, 2025
Commit Message: clean up: remove senseless interfaces Additional Description: The getTransportSocketFactoryContext() and the secretManager()/singletonManager() of ClusterManagerFactory is make no sense now and could be removed safely. Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wangbaiping(wbpcode) <[email protected]> Signed-off-by: Ting Pan <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Jul 17, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Jul 17, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Jul 17, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Jul 17, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Jul 17, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
viktor-kurchenko
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 17, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
viktor-kurchenko
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 17, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
viktor-kurchenko
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 18, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Jul 24, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
viktor-kurchenko
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 24, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
viktor-kurchenko
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 24, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 29, 2025
Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 29, 2025
Adjust cilium filter Relates: envoyproxy/envoy#39442 Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 29, 2025
Relates: envoyproxy/envoy#39442 Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
sayboras
pushed a commit
to viktor-kurchenko/proxy
that referenced
this pull request
Jul 29, 2025
Relates: envoyproxy/envoy#39442 Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
jrajahalme
pushed a commit
to cilium/proxy
that referenced
this pull request
Jul 29, 2025
Relates: envoyproxy/envoy#39442 Relates: envoyproxy/envoy#39460 Signed-off-by: Tam Mach <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: clean up: remove senseless interfaces
Additional Description:
The getTransportSocketFactoryContext() and the secretManager()/singletonManager() of ClusterManagerFactory is make no sense now and could be removed safely.
Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.