fix: credential injector init manager#38798
Merged
yanavlasov merged 2 commits intoenvoyproxy:mainfrom Mar 26, 2025
Merged
Conversation
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Contributor
|
Looks good. Would you be able to add test as well, please? |
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Member
Author
Done. @yanavlasov |
Member
Author
|
ping |
Member
Author
yanavlasov
approved these changes
Mar 26, 2025
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
fix: envoyproxy/gateway#5496 (comment) We should use the initManager in the DualInfo because the Credential Injector can be used for both HCM filter and upstream filter. Using the initManger from the ServerFactoryContext for HCM filter causes the secret to be added to the server initManager when it's already in the initialized state. Change log should not be required as this fixes a bug introduced in [a RP](envoyproxy#38398) that just merged after v1.33.0 . @yanavlasov --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
fix: envoyproxy/gateway#5496 (comment) We should use the initManager in the DualInfo because the Credential Injector can be used for both HCM filter and upstream filter. Using the initManger from the ServerFactoryContext for HCM filter causes the secret to be added to the server initManager when it's already in the initialized state. Change log should not be required as this fixes a bug introduced in [a RP](envoyproxy#38398) that just merged after v1.33.0 . @yanavlasov --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: envoyproxy/gateway#5496 (comment)
We should use the initManager in the DualInfo because the Credential Injector can be used for both HCM filter and upstream filter. Using the initManger from the ServerFactoryContext for HCM filter causes the secret to be added to the server initManager when it's already in the initialized state.
Change log should not be required as this fixes a bug introduced in a RP that just merged after v1.33.0 .
@yanavlasov