Make ip_tagging exception free#38460
Merged
RyanTheOptimist merged 6 commits intoenvoyproxy:mainfrom Feb 19, 2025
Merged
Conversation
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Member
Author
|
/coverage |
|
Coverage for this Pull Request will be rendered here: The coverage results are (re-)rendered each time the CI |
Signed-off-by: Takeshi Yoneda <[email protected]>
Member
Author
|
/assign @alyssawilk |
Signed-off-by: Takeshi Yoneda <[email protected]>
adisuissa
previously approved these changes
Feb 18, 2025
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
LGTM!
Assigning @RyanTheOptimist as Alyssa is OOO.
/assign @RyanTheOptimist
test/extensions/filters/http/ip_tagging/ip_tagging_filter_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Takeshi Yoneda <[email protected]>
RyanTheOptimist
approved these changes
Feb 19, 2025
eric846
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Feb 25, 2025
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update .bazelrc with changes from envoyproxy/envoy#38477 - Update source/client/process_impl.cc with API changes to envoyproxy/envoy@a1cdaed - Update tools/code_format/config.yaml to envoyproxy/envoy#38460 and envoyproxy/envoy#38398 Signed-off-by: Tom Zhang <[email protected]>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
Commit Message: Make ip_tagging exception free Additional Description: Risk Level: low Testing: existing ones Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Takeshi Yoneda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Make ip_tagging exception free
Additional Description:
Risk Level: low
Testing: existing ones
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a