factory context: extend ServerFactoryContext with getTransportSocketFactoryContext#38399
Merged
mattklein123 merged 4 commits intoenvoyproxy:mainfrom Feb 12, 2025
Conversation
…actoryContext Signed-off-by: Jacek Ewertowski <[email protected]>
jewertow
commented
Feb 11, 2025
| testing::NiceMock<Upstream::MockClusterManager> cluster_manager_; | ||
| testing::NiceMock<Event::MockDispatcher> dispatcher_; | ||
| testing::NiceMock<MockDrainManager> drain_manager_; | ||
| TransportSocketFactoryContext* transport_socket_factory_context_; |
Contributor
Author
There was a problem hiding this comment.
I didn't use testing::NiceMock<MockTransportSocketFactoryContext>, because that caused circular dependency error.
Signed-off-by: Jacek Ewertowski <[email protected]>
jewertow
force-pushed
the
server-factor-context-transport-socket-factory
branch
from
7361bc9 to
a387cad
Compare
Signed-off-by: Jacek Ewertowski <[email protected]>
Signed-off-by: Jacek Ewertowski <[email protected]>
mattklein123
approved these changes
Feb 12, 2025
eric846
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Feb 15, 2025
- Updated `tools/code_format/config.yaml` - no changes in `.bazelrc`, `.bazelversion`, `ci/run_envoy_docker.sh.` or `tools/gen_compilation_database.py` - `ServerFactoryContext` was extended with `getTransportSocketFactoryContext` in envoyproxy/envoy#38399, extended `NighthawkServerFactoryContext` with `getTransportSocketFactoryContext` to match these changes Signed-off-by: Sebastian Avila <[email protected]>
mattklein123
pushed a commit
that referenced
this pull request
Feb 15, 2025
Commit Message: http: make credential injector filter a dual filter Additional Description: This change allows users to inject credentials to HTTP CONNECT requests sent to the upstream tunnel proxy. Credentials can come from secrets (static and sds) for example for Basic auth, or from authorization servers in case of OAuth2. Risk Level: Testing: Integration test was implemented. Docs Changes: TODO Release Notes: done Fixes #13809 This approach to injecting Proxy-Authorization was suggested by @alyssawilk [here](#13809 (comment)) This PR must be merged first: #38399. [Here](https://github.com/jewertow/envoy-playground/blob/master/inject-proxy-authorization/envoy.filters.http.upstream.credential_injector/envoy.yaml) you can see example configuration for credential injector upstream filter. --------- Signed-off-by: Jacek Ewertowski <[email protected]>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
…actoryContext (envoyproxy#38399) Commit Message: factory context: extend ServerFactoryContext with getTransportSocketFactoryContext Additional Description: This change is necessary to allow upstream filters reading secrets from SDS. Risk Level: low Testing: - Docs Changes: Not needed as it is only an internal change. Release Notes: Not needed as it is only an internal change. Platform Specific Features: - This change is necessary to unblock: 1. injecting credentials to upstream requests envoyproxy#38398 2. reading image pull secret by upstream wasm filters envoyproxy#37635 --------- Signed-off-by: Jacek Ewertowski <[email protected]>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
Commit Message: http: make credential injector filter a dual filter Additional Description: This change allows users to inject credentials to HTTP CONNECT requests sent to the upstream tunnel proxy. Credentials can come from secrets (static and sds) for example for Basic auth, or from authorization servers in case of OAuth2. Risk Level: Testing: Integration test was implemented. Docs Changes: TODO Release Notes: done Fixes envoyproxy#13809 This approach to injecting Proxy-Authorization was suggested by @alyssawilk [here](envoyproxy#13809 (comment)) This PR must be merged first: envoyproxy#38399. [Here](https://github.com/jewertow/envoy-playground/blob/master/inject-proxy-authorization/envoy.filters.http.upstream.credential_injector/envoy.yaml) you can see example configuration for credential injector upstream filter. --------- Signed-off-by: Jacek Ewertowski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: factory context: extend ServerFactoryContext with getTransportSocketFactoryContext
Additional Description: This change is necessary to allow upstream filters reading secrets from SDS.
Risk Level: low
Testing: -
Docs Changes: Not needed as it is only an internal change.
Release Notes: Not needed as it is only an internal change.
Platform Specific Features: -
This change is necessary to unblock: