flake: fix credential_injector_oauth_integration_test/RetryOnClusterNotFound#38274
Merged
wbpcode merged 1 commit intoenvoyproxy:mainfrom Feb 5, 2025
Merged
Conversation
…otFound Signed-off-by: Vikas Choudhary (vikasc) <[email protected]>
wbpcode
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: test flake: fix credential_injector_oauth_integration_test/RetryOnClusterNotFound
Additional Description:
Test was verifying stat increment on every retry. Test was relying on retry timeout to approximate the stat increment verification timeout. This can fail based on resources/load on the underlying machine.
Now test has been changed from verifying stat increment on every failed retry to if any retry happened which will be more stable.
fixes: #38263